Check inlinee arity in mir inliner #133357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
cjgillot
reviewed
Nov 25, 2024
| if args.len() != callee_body.args_iter().len() { | ||
| return Err("arg arity mismatch"); | ||
| } | ||
|
|
There was a problem hiding this comment.
How can this even happen???
In the test, typeck gives an error. We bail out if the callee is tainted by errors, so we should have bailed out somewhere. Or are we missing tainting?
There was a problem hiding this comment.
We don't taint a body if it's incompatible with its trait definition. But this PR is made obsolete by #133365, which does ensure we never resolve to an impl if it's incompatible with the definition of the trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the number of args we're inlining is actually the number of args in our call signature.
Fixes #121127
Fixes #129075
Fixes #129127
Fixes #131294
r? cjgillot or re-roll