remove is_trivially_const_drop

[RalfJung]

I'm not sure this still brings any perf benefits, so let's benchmark this.

r? @compiler-errors

[rustbot]

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

[RalfJung]

@bors try
@rust-timer queue

[bors]

⌛ Trying commit 5645d66 with merge b40cffa...

[compiler-errors]

if perf is neutral then r=me

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[RalfJung]

@bors try

[bors]

⌛ Trying commit bd00de7 with merge 5f8e7058d31eaf1c73bf220322209f5bec6532b1...

[bors]

☀️ Try build successful - checks-actions
Build commit: 5f8e705 (5f8e7058d31eaf1c73bf220322209f5bec6532b1)

[rust-timer]

Finished benchmarking commit (5f8e705): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.6%, secondary 1.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	1.2%	[1.0%, 1.5%]	2
Improvements ✅ (primary)	-1.8%	[-1.8%, -1.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[-1.8%, 3.0%]	2

Cycles

Results (secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 795.253s -> 796.142s (0.11%)
Artifact size: 336.22 MiB -> 336.25 MiB (0.01%)

[RalfJung]

@bors r=compiler-errors

[bors]

📌 Commit bd00de7 has been approved by compiler-errors

It is now in the queue for this repository.

[compiler-errors]

@bors rollup