always create `DefId`s for anon consts #133468

lcnr · 2024-11-25T17:52:29Z

but don't use them anywhere, we intentionally don't encode them in the crate metadata.

best reviewed by disabling whitespace.

This pretty much reimplements #133285 while adding the tests of #133455. Fixes #133064

r? @BoxyUwU @compiler-errors

BoxyUwU · 2024-11-25T18:13:48Z

@bors r+ rollup=never

yay.

bors · 2024-11-25T18:13:51Z

📌 Commit afaf8b5 has been approved by BoxyUwU

It is now in the queue for this repository.

bors · 2024-11-26T19:40:04Z

☔ The latest upstream changes (presumably #133500) made this pull request unmergeable. Please resolve the merge conflicts.

no longer necessary as we now always create a ` DefId` for anon-consts

BoxyUwU · 2024-11-28T12:42:03Z

rebased, @bors r+ rollup=never

bors · 2024-11-28T12:42:06Z

📌 Commit d401a07 has been approved by BoxyUwU

It is now in the queue for this repository.

bors · 2024-11-28T15:58:21Z

⌛ Testing commit d401a07 with merge 7e565cc...

bors · 2024-11-28T18:59:49Z

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing 7e565cc to master...

rust-timer · 2024-11-28T22:32:52Z

Finished benchmarking commit (7e565cc): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.2%	[4.2%, 4.2%]	1
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-0.6%	[-1.0%, -0.3%]	9
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results (secondary -3.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-3.6%, -3.6%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Binary size

Results (primary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.4%]	16
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.7%, -0.1%]	36
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.7%, 0.4%]	52

Bootstrap: 791.695s -> 792.194s (0.06%)
Artifact size: 335.88 MiB -> 335.92 MiB (0.01%)

lqd · 2024-11-29T07:01:07Z

The coercions regression was noise and was fixed in the next merge

@rustbot label: +perf-regression-triaged

…id, r=compiler-errors Use correct `hir_id` for array const arg infers Fixes rust-lang#133771 `self.next_id()` results in the `DefId` for the const argument, created from the hack introduced by rust-lang#133468, having no `HirId` associated with it. This then results in an ICE in metadata encoding. Fixing this then results in *another* ICE where `encode_defs` was not skipping encoding `type_of` and other queries for `DefId`s when they correspond to a `ConstArgKind::Infer` node. This only reproduces with a library crate as metadata is not encoded for binaries, and apparently we had 0 tests for `generic_arg_infer` for array lengths in a library crate so this was not caught :< cc rust-lang#133589 `@voidc` r? `@compiler-errors` `@lcnr`

…id, r=compiler-errors Use correct `hir_id` for array const arg infers Fixes rust-lang#133771 `self.next_id()` results in the `DefId` for the const argument, created from the hack introduced by rust-lang#133468, having no `HirId` associated with it. This then results in an ICE in metadata encoding. Fixing this then results in *another* ICE where `encode_defs` was not skipping encoding `type_of` and other queries for `DefId`s when they correspond to a `ConstArgKind::Infer` node. This only reproduces with a library crate as metadata is not encoded for binaries, and apparently we had 0 tests for `generic_arg_infer` for array lengths in a library crate so this was not caught :< cc rust-lang#133589 ``@voidc`` r? ``@compiler-errors`` ``@lcnr``

…id, r=compiler-errors Use correct `hir_id` for array const arg infers Fixes rust-lang#133771 `self.next_id()` results in the `DefId` for the const argument, created from the hack introduced by rust-lang#133468, having no `HirId` associated with it. This then results in an ICE in metadata encoding. Fixing this then results in *another* ICE where `encode_defs` was not skipping encoding `type_of` and other queries for `DefId`s when they correspond to a `ConstArgKind::Infer` node. This only reproduces with a library crate as metadata is not encoded for binaries, and apparently we had 0 tests for `generic_arg_infer` for array lengths in a library crate so this was not caught :< cc rust-lang#133589 ```@voidc``` r? ```@compiler-errors``` ```@lcnr```

…id, r=compiler-errors Use correct `hir_id` for array const arg infers Fixes rust-lang#133771 `self.next_id()` results in the `DefId` for the const argument, created from the hack introduced by rust-lang#133468, having no `HirId` associated with it. This then results in an ICE in metadata encoding. Fixing this then results in *another* ICE where `encode_defs` was not skipping encoding `type_of` and other queries for `DefId`s when they correspond to a `ConstArgKind::Infer` node. This only reproduces with a library crate as metadata is not encoded for binaries, and apparently we had 0 tests for `generic_arg_infer` for array lengths in a library crate so this was not caught :< cc rust-lang#133589 `@voidc` r? `@compiler-errors` `@lcnr`

Rollup merge of rust-lang#133779 - BoxyUwU:array_const_arg_infer_hir_id, r=compiler-errors Use correct `hir_id` for array const arg infers Fixes rust-lang#133771 `self.next_id()` results in the `DefId` for the const argument, created from the hack introduced by rust-lang#133468, having no `HirId` associated with it. This then results in an ICE in metadata encoding. Fixing this then results in *another* ICE where `encode_defs` was not skipping encoding `type_of` and other queries for `DefId`s when they correspond to a `ConstArgKind::Infer` node. This only reproduces with a library crate as metadata is not encoded for binaries, and apparently we had 0 tests for `generic_arg_infer` for array lengths in a library crate so this was not caught :< cc rust-lang#133589 `@voidc` r? `@compiler-errors` `@lcnr`

rustbot assigned BoxyUwU Nov 25, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 25, 2024

lcnr mentioned this pull request Nov 25, 2024

def_collector: rework trivial const-arg handling #133455

Closed

lcnr force-pushed the uwu4 branch 2 times, most recently from 7b7c9b1 to afaf8b5 Compare November 25, 2024 18:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2024

rust-lang deleted a comment from petrochenkov Nov 25, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 26, 2024

lcnr added 4 commits November 28, 2024 12:20

add tests

467e200

always create DefIds when lowering anon-consts

94131bd

ast_lowering: rm separate def_id_parent

23ba2d1

no longer necessary as we now always create a ` DefId` for anon-consts

update comment

d401a07

BoxyUwU force-pushed the uwu4 branch from afaf8b5 to d401a07 Compare November 28, 2024 12:22

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 28, 2024

bors merged commit 7e565cc into rust-lang:master Nov 28, 2024
7 checks passed

rustbot added this to the 1.85.0 milestone Nov 28, 2024

rustbot added the perf-regression Performance regression. label Nov 28, 2024

rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 29, 2024

This was referenced Dec 2, 2024

ICE: No HirId for DefId #133771

Closed

Use correct hir_id for array const arg infers #133779

Merged

compiler-errors mentioned this pull request Feb 19, 2025

ICE：no entry for node id: NodeId(13) #137267

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

always create `DefId`s for anon consts #133468

always create `DefId`s for anon consts #133468

lcnr commented Nov 25, 2024 •

edited

Loading

BoxyUwU commented Nov 25, 2024

bors commented Nov 25, 2024

bors commented Nov 26, 2024

BoxyUwU commented Nov 28, 2024

bors commented Nov 28, 2024

bors commented Nov 28, 2024

bors commented Nov 28, 2024

rust-timer commented Nov 28, 2024

lqd commented Nov 29, 2024

always create DefIds for anon consts #133468

always create DefIds for anon consts #133468

Conversation

lcnr commented Nov 25, 2024 • edited Loading

BoxyUwU commented Nov 25, 2024

bors commented Nov 25, 2024

bors commented Nov 26, 2024

BoxyUwU commented Nov 28, 2024

bors commented Nov 28, 2024

bors commented Nov 28, 2024

bors commented Nov 28, 2024

rust-timer commented Nov 28, 2024

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

lqd commented Nov 29, 2024

always create `DefId`s for anon consts #133468

always create `DefId`s for anon consts #133468

lcnr commented Nov 25, 2024 •

edited

Loading