Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const evaluation error UI test. #133785

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

HypheX
Copy link
Contributor

@HypheX HypheX commented Dec 3, 2024

This closes #78834

@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2024

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 3, 2024
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting in this test goes kinda crazy but according to rustfmt it's valid so whatever

@compiler-errors
Copy link
Member

Test name could be improved to talk about how it's in a const generic default but w/e

r? compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 3, 2024

📌 Commit 3b2ff90 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned estebank Dec 3, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2024
@Zalathar
Copy link
Contributor

Zalathar commented Dec 3, 2024

formatting in this test goes kinda crazy but according to rustfmt it's valid so whatever

I'm pretty sure x fmt doesn't touch ui tests, because it would break error comments.

(The formatting is atypical, but in the context of a tiny UI test I don't think it's a big deal.)

@HypheX
Copy link
Contributor Author

HypheX commented Dec 3, 2024

formatting in this test goes kinda crazy but according to rustfmt it's valid so whatever

😆 Yeah, it's wild. I actually ran it through rustfmt and it made it even worse on my end.

@compiler-errors
Copy link
Member

@Zalathar: I am aware. I mean I ran it through rustfmt locally.

jhpratt added a commit to jhpratt/rust that referenced this pull request Dec 3, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 3, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#132723 (Unify `sysroot_target_{bin,lib}dir` handling)
 - rust-lang#133041 (Print name of env var in `--print=deployment-target`)
 - rust-lang#133325 (Reimplement `~const` trait specialization)
 - rust-lang#133395 (Add simd_relaxed_fma intrinsic)
 - rust-lang#133517 (Deeply normalize when computing implied outlives bounds)
 - rust-lang#133785 (Add const evaluation error UI test.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8ae1114 into rust-lang:master Dec 3, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 3, 2024
Rollup merge of rust-lang#133785 - HypheX:add-ui-test, r=compiler-errors

Add const evaluation error UI test.

This closes rust-lang#78834
@rustbot rustbot added this to the 1.85.0 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong error about the size of a parameter not being known at compiletime
6 participants