Skip to content

Fix const conditions for RPITITs #133926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix const conditions for RPITITs #133926

merged 1 commit into from
Dec 18, 2024

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Dec 5, 2024 •
edited
Loading

Fixes #133918

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 5, 2024
@lcnr
Copy link
Contributor

lcnr commented Dec 17, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 17, 2024

📌 Commit 50f6238 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 17, 2024
@jieyouxu
Rollup merge of rust-lang#133926 - compiler-errors:const-conditions, …
b0b6b62 
…r=lcnr

Fix const conditions for RPITITs

Fixes rust-lang#133918

r? lcnr
@jieyouxu jieyouxu mentioned this pull request Dec 17, 2024
Closed
@jieyouxu
Copy link
Member

Maybe failed in rollup, e.g.:

  error[E0015]: cannot call non-const operator in constant functions
  Error:   --> /checkout/tests/ui/traits/const-traits/const-impl-trait.rs:12:5
     |
  LL |     a == a
     |     ^^^^^^
     |
     = note: calls in constant functions are limited to constant functions, tuple structs and tuple variants

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 17, 2024
@jieyouxu jieyouxu closed this Dec 17, 2024
@jieyouxu jieyouxu reopened this Dec 17, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member Author

@bors r=lcnr

@bors
Copy link
Collaborator

bors commented Dec 18, 2024

📌 Commit 4977640 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 18, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 18, 2024
@jieyouxu
Rollup merge of rust-lang#133926 - compiler-errors:const-conditions, …
c437b03 
…r=lcnr

Fix const conditions for RPITITs

Fixes rust-lang#133918

r? lcnr
@jieyouxu jieyouxu mentioned this pull request Dec 18, 2024
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 18, 2024
@jieyouxu
Rollup merge of rust-lang#133926 - compiler-errors:const-conditions, …
5c3829f 
…r=lcnr

Fix const conditions for RPITITs

Fixes rust-lang#133918

r? lcnr
@jieyouxu jieyouxu mentioned this pull request Dec 18, 2024
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 18, 2024
@jieyouxu
Rollup merge of rust-lang#133926 - compiler-errors:const-conditions, …
322962a 
…r=lcnr

Fix const conditions for RPITITs

Fixes rust-lang#133918

r? lcnr
@jieyouxu jieyouxu mentioned this pull request Dec 18, 2024
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 18, 2024
@jieyouxu
Rollup merge of rust-lang#133926 - compiler-errors:const-conditions, …
df5e242 
…r=lcnr

Fix const conditions for RPITITs

Fixes rust-lang#133918

r? lcnr
@jieyouxu jieyouxu mentioned this pull request Dec 18, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2024
@bors
Auto merge of rust-lang#134458 - jieyouxu:rollup-9mxt9ed, r=jieyouxu
795994e 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#133702 (Variants::Single: do not use invalid VariantIdx for uninhabited enums)
 - rust-lang#133926 (Fix const conditions for RPITITs)
 - rust-lang#134161 (Overhaul token cursors)
 - rust-lang#134253 (Overhaul keyword handling)
 - rust-lang#134394 (Clarify the match ergonomics 2024 migration lint's output)
 - rust-lang#134420 (refactor: replace &PathBuf with &Path to enhance generality)
 - rust-lang#134444 (Fix `x build --stage 1 std` when using cg_cranelift as the default backend)
 - rust-lang#134452 (fix(LazyCell): documentation of get[_mut] was wrong)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu jieyouxu mentioned this pull request Dec 18, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2024
@bors
Auto merge of rust-lang#134470 - jieyouxu:rollup-kld7kmk, r=jieyouxu
a52085d 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#130786 ( mir-opt: a sub-BB of a cleanup BB must also be a cleanup BB in `EarlyOtherwiseBranch`)
 - rust-lang#133926 (Fix const conditions for RPITITs)
 - rust-lang#134161 (Overhaul token cursors)
 - rust-lang#134253 (Overhaul keyword handling)
 - rust-lang#134394 (Clarify the match ergonomics 2024 migration lint's output)
 - rust-lang#134399 (Do not do if ! else, use unnegated cond and swap the branches instead)
 - rust-lang#134420 (refactor: replace &PathBuf with &Path to enhance generality)
 - rust-lang#134436 (tests/assembly/asm: Remove uses of rustc_attrs and lang_items features by using minicore)
 - rust-lang#134444 (Fix `x build --stage 1 std` when using cg_cranelift as the default backend)
 - rust-lang#134452 (fix(LazyCell): documentation of get[_mut] was wrong)
 - rust-lang#134460 (Merge some patterns together)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 81fccef into rust-lang:master Dec 18, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2024
@rust-timer
Unrolled build for rust-lang#133926
e4d2251 
Rollup merge of rust-lang#133926 - compiler-errors:const-conditions, r=lcnr

Fix const conditions for RPITITs

Fixes rust-lang#133918

r? lcnr
@fee1-dead fee1-dead mentioned this pull request Dec 30, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
6 participants
@compiler-errors @lcnr @bors @jieyouxu @rust-log-analyzer @rustbot