-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: remove eq for clean::Attributes #133960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @notriddle rustbot has assigned @notriddle. Use |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Dec 6, 2024
fmease
changed the title
remove eq for attributes
rustdoc: remove eq for clean::Attributes
Dec 6, 2024
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 6, 2024
notriddle
approved these changes
Dec 6, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 6, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#130209 (Stabilize `std::io::ErrorKind::CrossesDevices`) - rust-lang#130254 (Stabilize `std::io::ErrorKind::QuotaExceeded`) - rust-lang#132187 (Add Extend impls for tuples of arity 1 through 12) - rust-lang#133875 (handle `--json-output` properly) - rust-lang#133934 (Do not implement unsafe auto traits for types with unsafe fields) - rust-lang#133954 (Hide errors whose suggestions would contain error constants or types) - rust-lang#133960 (rustdoc: remove eq for clean::Attributes) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 7, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#130209 (Stabilize `std::io::ErrorKind::CrossesDevices`) - rust-lang#130254 (Stabilize `std::io::ErrorKind::QuotaExceeded`) - rust-lang#132187 (Add Extend impls for tuples of arity 1 through 12) - rust-lang#133875 (handle `--json-output` properly) - rust-lang#133934 (Do not implement unsafe auto traits for types with unsafe fields) - rust-lang#133954 (Hide errors whose suggestions would contain error constants or types) - rust-lang#133960 (rustdoc: remove eq for clean::Attributes) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 7, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#130209 (Stabilize `std::io::ErrorKind::CrossesDevices`) - rust-lang#130254 (Stabilize `std::io::ErrorKind::QuotaExceeded`) - rust-lang#132187 (Add Extend impls for tuples of arity 1 through 12) - rust-lang#133875 (handle `--json-output` properly) - rust-lang#133934 (Do not implement unsafe auto traits for types with unsafe fields) - rust-lang#133954 (Hide errors whose suggestions would contain error constants or types) - rust-lang#133960 (rustdoc: remove eq for clean::Attributes) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 7, 2024
Rollup merge of rust-lang#133960 - jdonszelmann:remove-eq-on-attributes, r=notriddle rustdoc: remove eq for clean::Attributes This change removes the `PartialEq` and `Eq` implementations from `Attributes`. This implementation was not used, and whether the implementation is useful at all is questionable. I care about removing it, because I'm working rust-lang#131229. While simplifying the representation of attributes, I intend to remove attr ids from attributes where possible. They're actually rarely useful. This piece of code uses them, but for no real reason, so I think simply removing the implementation makes most sense. Let me know if there are major objections to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the
PartialEq
andEq
implementations fromAttributes
. This implementation was not used, and whether the implementation is useful at all is questionable. I care about removing it, because I'm working #131229. While simplifying the representation of attributes, I intend to remove attr ids from attributes where possible. They're actually rarely useful. This piece of code uses them, but for no real reason, so I think simply removing the implementation makes most sense. Let me know if there are major objections to this.