-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[CI test] Turn rustc-dev-guide
into a subtree
#134083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* adding links * Update src/rustc-driver-interacting-with-the-ast.md Co-authored-by: Tshepang Mbambo <tshepang@gmail.com> * redo links and formatting * Update rustc-driver-interacting-with-the-ast.md --------- Co-authored-by: Tshepang Mbambo <tshepang@gmail.com>
Minor additions and resorting.
A sequel to rust-lang#1883, this covers diagnostic naming changes from rust-lang/pull/121489, rust-lang/pull/121780, and rust-lang/pull/122132.
* Extract Bootstrap into its own section Add brief explanation for `Step` and `Builder::ensure` as core Bootstrap internal concepts. * Drop common commands page (use `x --help` instead) * Add `make` as an alternative entry point * Add src/bootstrap/README.md link
* Update test-implementation.md * Update test-implementation.md
* Update rustdoc-internals.md Minor updates to syntax and some clarifications. * updates * Update rustdoc-internals.md
The 'read this chapter' link under the 'What is x.py?' section returned a Document not found (404) error.
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
Signed-off-by: JohnEndson <jiayuzhen@outlook.com>
It's super annoying to be forced to use this bad convention, and apparently everyone agrees. The only reason no improvements have been done is because those were blocked on writing a better checker. I strongly believe that no checker is better than a bad checker, so let's just delete it in the meantime. I kindly asked anyone who sees this to complain about overly long sentences in review in the future, I think we can make this turn out fine.
* Add quickstart for how to build and run the compiler The chapter is quite long, and a lot of the information is, while valuable, not very important for newcomers. I think it makes sense to have a condensed version for anyone just wanting to get started with only the most important information. * A few improvements to quickstart
"And" should be "An" - one instance.
Co-authored-by: Eric Huss <eric@huss.org>
This comment has been minimized.
This comment has been minimized.
Before merging this, can you please coordinate with me to get the automation and such ready? |
I probably do not intend to merge this PR 😁 It's mostly just for testing and discussions. Once we figure out the right way forward and prepare the automation, I'll probably create another one. |
You might also want to update the (Or just remove |
fd3ace8
to
4416267
Compare
Yeah, I did that in the last few commits, forgot to push them before. The I added a |
This comment has been minimized.
This comment has been minimized.
4416267
to
c40accb
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #134492) made this pull request unmergeable. Please resolve the merge conflicts. |
rustc-dev-guide
into a subtreerustc-dev-guide
into a (Josh) subtree
rustc-dev-guide
into a (Josh) subtreerustc-dev-guide
into a subtree
Closing in favour of #134907. |
This is a test PR to check what happens if we move
rustc-dev-guide
into a subtree. This move was discussed on Zulip.Used instructions from https://gist.github.com/Nikita240/0c98cea8f53a15e69699cd8bc40657c4. More specifically, ran:
r? @jieyouxu