Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify rustc_mir_dataflow::abs_domain. #134152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify rustc_mir_dataflow::abs_domain. #134152

wants to merge 1 commit into from
+11 −37

Conversation

nnethercote
Copy link
Contributor

rustc_mir_dataflow has a typedef AbstractElem that is equal to ProjectionElem<AbstractOperand, AbstractType>. AbstractOperand and AbstractType are both unit types. There is also has a trait Lift to convert a PlaceElem to an AbstractElem.

But rustc_mir_middle already has a typedef ProjectionKind that is equal to ProjectionElem<(), ()>, which is equivalent to AbstractElem. So this commit reuses ProjectionKind in rustc_mir_dataflow, removes AbstractElem, and simplifies the Lift trait.

r? @pnkfelix

@nnethercote
Simplify rustc_mir_dataflow::abs_domain.
67df7cb 
`rustc_mir_dataflow` has a typedef `AbstractElem` that is equal to
`ProjectionElem<AbstractOperand, AbstractType>`. `AbstractOperand` and
`AbstractType` are both unit types. There is also has a trait `Lift` to
convert a `PlaceElem` to an `AbstractElem`.

But `rustc_mir_middle` already has a typedef `ProjectionKind` that is
equal to `ProjectionElem<(), ()>`, which is equivalent to
`AbstractElem`. So this commit reuses `ProjectionKind` in
`rustc_mir_dataflow`, removes `AbstractElem`, and simplifies the `Lift`
trait.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnethercote @pnkfelix @rustbot