Remove support for specializing ToString outside the standard library

[bjorn3]

This is the only trait specializable outside of the standard library. Before stabilizing specialization we will probably want to remove support for this. It was originally made specializable to allow a more efficient ToString in libproc_macro back when this way the only way to get any data out of a TokenStream. We now support getting individual tokens, so proc macros no longer need to call it as often.

[rustbot]

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[petrochenkov]

@bors try @rust-timer queue

[bors]

⌛ Trying commit b805f30 with merge f557de4...

[bors]

☀️ Try build successful - checks-actions
Build commit: f557de4 (f557de4c3dacd27cfe1deb8a6286a175e03ea4b8)

[lqd]

@rust-timer build f557de4

[rust-timer]

Finished benchmarking commit (f557de4): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.5%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.5%, 0.5%]	4

Max RSS (memory usage)

Results (primary -3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.0%	[-8.4%, -2.4%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.2%	[-8.4%, 2.1%]	7

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.0%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	26
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	11
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	6
All ❌✅ (primary)	0.0%	[-0.2%, 0.1%]	37

Bootstrap: 770.497s -> 767.005s (-0.45%)
Artifact size: 330.36 MiB -> 330.49 MiB (0.04%)

[petrochenkov]

Perf is ok, but the CI is still failing.
@rustbot author

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[bjorn3]

@rustbot ready

[petrochenkov]

@bors r+

[bors]

📌 Commit 3f3f27b has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3f3f27b with merge 4790a43...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 4790a43 to master...

[rust-timer]

Finished benchmarking commit (4790a43): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

• If the regression was expected or you think it can be justified,
  please write a comment with sufficient written justification, and add
  @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
• If you think that you know of a way to resolve the regression, try to create
  a new PR with a fix for the regression.
• If you do not understand the regression or you think that it is just noise,
  you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
  were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.5%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.4%, 0.5%]	4

Max RSS (memory usage)

Results (primary -2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	5.6%	[4.6%, 6.5%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-6.9%	[-12.8%, -2.7%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-12.8%, 6.5%]	6

Cycles

Results (primary -4.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.9%	[-4.9%, -4.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.9%	[-4.9%, -4.9%]	1

Binary size

Results (primary 0.0%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	28
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	10
Improvements ✅ (secondary)	-0.2%	[-0.4%, -0.1%]	6
All ❌✅ (primary)	0.0%	[-0.2%, 0.3%]	38

Bootstrap: 770.572s -> 769.38s (-0.15%)
Artifact size: 333.16 MiB -> 333.20 MiB (0.01%)