(Re-)return adjustment target if adjust kind is never-to-any

[jieyouxu]

This PR fixes #134162 where we ICE'd on

fn main() {
    struct X;
    let _ = [X] == [panic!(); 2];
}

In #121208 (comment), there was a change

- if let Some(adjustments) = self.typeck_results.borrow().adjustments().get(expr.hir_id) {
-     let reported = self.dcx().span_delayed_bug(
-         expr.span,
-         "expression with never type wound up being adjusted",
-     );
-     return if let [Adjustment { kind: Adjust::NeverToAny, target }] = &adjustments[..] {
-         target.to_owned()
-     } else {
-         Ty::new_error(self.tcx(), reported)
-     };
- }
+ if let Some(_) = self.typeck_results.borrow().adjustments().get(expr.hir_id) {
+     self.dcx()
+         .span_bug(expr.span, "expression with never type wound up being adjusted");
+ }

It turned out returning the adjustment target if the adjustment kind is NeverToAny is necessary, as otherwise we will go through a series of delay_bugs and eventually find that we constructed a TyKind::Error without having actually emitted an error.

This PR addresses that by re-returning the adjustment target if the adjustment kind is NeverToAny, partially reverting this change from #121208.

This PR has two commits:

1. The first commit adds a regression test for ICE: this path really should be doomed #134162, which will ICE (on stable 1.83.0, beta and nightly 2024-12-13).
2. The second commit is the partial revert, which will fix the ICE.

cc @nnethercote FYI as this is related to #121208 changes. The changes from #121208 exposed that we lacked test coverage for the code pattern reported in #134162.

[rustbot]

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[compiler-errors]

@bors r+ rollup

[bors]

📌 Commit 2e8ce2a has been approved by compiler-errors

It is now in the queue for this repository.

[matthiaskrgr]

@bors r-
a test has been added tests/crashes/134162.rs , need to be removed and re-r+'d I think

[jieyouxu]

Removed the redundant crashes test (which is the larger version of the regression test added).

@bors r=@compiler-errors

[bors]

📌 Commit d15315c has been approved by compiler-errors

It is now in the queue for this repository.