-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PtrMetadata
instead of Len
in slice drop shims
#134326
Conversation
Let's see if the errors from the previous PR reproduce |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…, r=<try> Use `PtrMetadata` instead of `Len` in slice drop shims I tried to do a bigger change in rust-lang#134297 which didn't work, so here's the part I really wanted: Removing another use of `Len`, in favour of `PtrMetadata`. Reusing the same reviewer from the last one: r? BoxyUwU
☀️ Try build successful - checks-actions |
Seems reasonable to me but I am not super familiar with nuances of MIR so I will assign someone else for a final review r? @saethlin |
@bors r+ rollup=iffy |
…, r=saethlin Use `PtrMetadata` instead of `Len` in slice drop shims I tried to do a bigger change in rust-lang#134297 which didn't work, so here's the part I really wanted: Removing another use of `Len`, in favour of `PtrMetadata`. Split into two commits where the first just adds a test, so you can look at the second commit to see how the drop shim for an array changes with this PR. Reusing the same reviewer from the last one: r? BoxyUwU
💔 Test failed - checks-actions |
Looks like @bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b22856d): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 2.1%, secondary 3.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -3.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 761.148s -> 762.237s (0.14%) |
…ewjasper Delete `Rvalue::Len` 🎉 Everything's moved to `PtrMetadata`, so we can get rid of the `Len` variant now. ~~Depends on rust-lang#134326, so draft until that lands~~ Ready! r? mir
I tried to do a bigger change in #134297 which didn't work, so here's the part I really wanted: Removing another use of
Len
, in favour ofPtrMetadata
.Split into two commits where the first just adds a test, so you can look at the second commit to see how the drop shim for an array changes with this PR.
Reusing the same reviewer from the last one:
r? BoxyUwU