-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up attribute parsing code and move data types to rustc_attr_data_structures
#134381
base: master
Are you sure you want to change the base?
Conversation
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval Some changes occurred in src/tools/clippy cc @rust-lang/clippy The Miri subtree was changed cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_codegen_gcc |
@rustbot label +A-attributes For the rustdoc changes, I only made that code depend on |
This comment has been minimized.
This comment has been minimized.
well, my last rebase had no conflicts, but clearly it didn't work very well anyway... 1s |
7179f3b
to
ff646ad
Compare
This comment has been minimized.
This comment has been minimized.
ff646ad
to
09d949d
Compare
a.out
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accidentally committed a test file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(even though it was removed in the second commit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, yea I had noticed but should've removed it from the first one haha
I reviewed some changes and the overall change. I'm just gonna assume all the individual parts have been moved correctly (as no tests have been touched, and the downstream usages are all just import changes, this appears so) @bors delegate+ r=me with the nit for a clean history |
✌️ @jdonszelmann, you can now approve this pull request! If @oli-obk told you to " |
09d949d
to
efb98b6
Compare
@bors p=6 (conflict-prone) |
(conflict-check) |
This change renames
rustc_attr
torustc_attr_parsing
, and splits up the parsing code. At the same time, all the data types used move torustc_attr_data_structures
. This is in preparation of also having a third crate:rustc_attr_validation
I initially envisioned this as two separate PRs, but I think doing it in one go reduces the number of ways others would have to rebase their changes on this. However, I can still split them.
r? @oli-obk (we already discussed how this is a first step in a larger plan)
For a more detailed plan on how attributes are going to change, see #131229
Edit: this looks like a giant PR, but the changes are actually rather trivial. Each commit is reviewable on its own, and mostly moves code around. No new logic is added.