Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize const_alloc_layout #134768

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

RalfJung
Copy link
Member

libs-api FCP passed in #67521

Fixes #67521

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 25, 2024
@jhpratt
Copy link
Member

jhpratt commented Dec 26, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Dec 26, 2024

📌 Commit 88b88f3 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2024
@bors
Copy link
Contributor

bors commented Dec 26, 2024

⌛ Testing commit 88b88f3 with merge a25032c...

@bors
Copy link
Contributor

bors commented Dec 26, 2024

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing a25032c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 26, 2024
@bors bors merged commit a25032c into rust-lang:master Dec 26, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 26, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a25032c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -1.9%, secondary -3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.9% [-2.1%, -1.4%] 4
Improvements ✅
(secondary)
-3.2% [-4.6%, -2.0%] 8
All ❌✅ (primary) -1.9% [-2.1%, -1.4%] 4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 764.604s -> 763.112s (-0.20%)
Artifact size: 330.49 MiB -> 330.55 MiB (0.02%)

@RalfJung RalfJung deleted the const_alloc_layout branch December 26, 2024 18:16
poliorcetics pushed a commit to poliorcetics/rust that referenced this pull request Dec 26, 2024
poliorcetics pushed a commit to poliorcetics/rust that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for const alloc::Layout
6 participants