bootstrap: Consolidate the macros for declaring compiletest test suites #134876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zalathar
added
A-testsuite
rustbot
added
S-waiting-on-review
|
In the future I would like to further reduce the use of macros for things like this, but this is a good intermediate step. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 29, 2024
…jieyouxu bootstrap: Consolidate the macros for declaring compiletest test suites Instead of using a dizzying assortment of different macros to declare these test suite steps, we can mostly just use one `test!` macro with a few optional named arguments. I'm pretty sure that this doesn't change any behaviour, but please do double-check each of the individual declarations.
This was referenced Dec 29, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#134799 (nits: Cleanups in `librustdoc::clean`) - rust-lang#134851 (docs: inline `alloc::ffi::c_str` types to `alloc::ffi`) - rust-lang#134869 (Bump compiler cc) - rust-lang#134876 (bootstrap: Consolidate the macros for declaring compiletest test suites) - rust-lang#134883 (bootstrap: Fix `./x check bootstrap` by moving `shared_helpers::tests`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2024
Rollup merge of rust-lang#134876 - Zalathar:bootstrap-test-macros, r=jieyouxu bootstrap: Consolidate the macros for declaring compiletest test suites Instead of using a dizzying assortment of different macros to declare these test suite steps, we can mostly just use one `test!` macro with a few optional named arguments. I'm pretty sure that this doesn't change any behaviour, but please do double-check each of the individual declarations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a dizzying assortment of different macros to declare these test suite steps, we can mostly just use one
test!macro with a few optional named arguments.I'm pretty sure that this doesn't change any behaviour, but please do double-check each of the individual declarations.