-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A couple datalog/borrowck cleanups #134914
Conversation
- remove unneeded type ascription - fix variable name - fix typo in comment - fix `var_origins` var and function name: these are `VarInfos`
this is specific to the old datalog implementation and wasn't noticed in the previous module move
this is mostly to remove imports of the polonius legacy module also what is going on in this function, what the...
this is specific to the old datalog implementation and wasn't noticed in the previous module move
it's a more natural place for diagnostics-related structures and functions
- rename it to what it does, buffer diagnostics - remove single-use functions - use derives
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (2061630): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 2.4%, secondary 3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 759.393s -> 759.925s (0.07%) |
As discussed on zulip, here's a chill one in between slightly more interesting PRs:
polonius
module (go to horn-clause jail, bonk!).diags
module and adiagnostics
module.As requested I've tried to have somewhat granular commits to ease review, but the last two or three could be squashed together, since they're all related to the
diags
module (but moving its contents is less tedious to check in its own commit).r? @jackh726