Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for C string literals in HiddenUnicodeCodepoints lint #134955

Closed
wants to merge 1 commit into from
Closed

Account for C string literals in HiddenUnicodeCodepoints lint #134955

wants to merge 1 commit into from

Conversation

compiler-errors
Copy link
Member

Also this changes the match to not return in case we add new kinds of literal strings in the future.

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 31, 2024
@compiler-errors compiler-errors mentioned this pull request Dec 31, 2024
Merged
@jieyouxu jieyouxu assigned jieyouxu and unassigned cjgillot Dec 31, 2024
@jieyouxu jieyouxu added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. L-text_direction_codepoint_in_literal Lint: text_direction_codepoint_in_literal labels Dec 31, 2024
@jieyouxu
Copy link
Member

Closing this in favor of the stacked PR #134956.

@jieyouxu jieyouxu closed this Dec 31, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#134956 - compiler-errors:format-args-hidden…
0c94f63 
…-chars, r=jieyouxu

Account for C string literals and `format_args` in `HiddenUnicodeCodepoints` lint

This is stacked on rust-lang#134955, and either that can land first or both of them can land together here. I split this out because this is a bit more involved of an impl.

Fixes rust-lang#94945
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 31, 2024
@rust-timer
Unrolled build for rust-lang#134956
34ba378 
Rollup merge of rust-lang#134956 - compiler-errors:format-args-hidden-chars, r=jieyouxu

Account for C string literals and `format_args` in `HiddenUnicodeCodepoints` lint

This is stacked on rust-lang#134955, and either that can land first or both of them can land together here. I split this out because this is a bit more involved of an impl.

Fixes rust-lang#94945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. L-text_direction_codepoint_in_literal Lint: text_direction_codepoint_in_literal S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@compiler-errors @rustbot @jieyouxu @cjgillot