Skip to content

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Jan 3, 2025

Minor versions from backtrace desynced with std (they still differs in patch numbers, but still better):
https://github.com/rust-lang/backtrace-rs/blob/4d7906bb24ae91ee6587127020d360f5298f9e7e/Cargo.toml#L44-L48

There is hidden bug here, let's see if CI can find it.

cc @workingjubilee

@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 3, 2025
@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@klensy
Copy link
Contributor Author

klensy commented Jan 3, 2025

The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)

No, not this bug.

@workingjubilee
Copy link
Member

what bug are you hunting?

@klensy
Copy link
Contributor Author

klensy commented Jan 3, 2025

bootstrap and CI happily accept warnings from cargo: check mingw-check job log to find:

2025-01-03T13:09:09.0664097Z �[1m�[33mwarning�[0m�[1m:�[0m profile package spec `adler` in profile `release` did not match any packages
2025-01-03T13:09:09.0664972Z 
2025-01-03T13:09:09.0665149Z 	Did you mean `adler2`?

which refers to:

adler.debug = 0

where i didn't replaced adler with adler2.

@workingjubilee
Copy link
Member

ahh.

@klensy
Copy link
Contributor Author

klensy commented Jan 4, 2025

Wow,

2025-01-04T10:20:08.1162350Z �[1m�[33mwarning�[0m�[1m:�[0m rustc_llvm@0.0.0: Inherited flag "-fembed-bitcode=all" is not supported by the currently used CC
2025-01-04T11:42:20.2875925Z �[0m�[1m�[33mwarning�[0m�[0m�[1m: unexpected `cfg` condition name: `test`�[0m
2025-01-04T11:42:20.2876899Z �[0m  �[0m�[0m�[1m�[38;5;12m--> �[0m�[0mcompiler/rustc_macros/src/symbols.rs:35:7�[0m

from #135095 dist-x86_64-linux

CI really don't care about warnings.

@workingjubilee
Copy link
Member

...lol.

anyway, this seems fine to me.

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 4, 2025

📌 Commit 4d3a028 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2025
@bors bors merged commit 6adcdc3 into rust-lang:master Jan 4, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 4, 2025
@Zalathar
Copy link
Contributor

Zalathar commented Jan 5, 2025

The warning about adler is not so “secret” any more; I see it on the command-line every time bootstrap builds library.

It's annoying that this is allowed in CI, but we should also fix the thing that it's warning about.

EDIT: Warning will be fixed by #135110.

@klensy
Copy link
Contributor Author

klensy commented Jan 5, 2025

Oh, i actually forgot to push fix myself here, haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants