bootstrap: Apply a clearer naming convention to many of the test steps #135071
+245
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
|
@rustbot experimental |
|
Failed to set assignee to
|
|
Please assign/ping me once it's ready. |
|
☔ The latest upstream changes (presumably #135086) made this pull request unmergeable. Please resolve the merge conflicts. |
This helper function is used by the test step type that contained it, but it is also used by other miri-related steps.
Zalathar
force-pushed
the
rename-test-steps
branch
from
5469f9c to
469a85d
Compare
This comment has been minimized.
This comment has been minimized.
Zalathar
force-pushed
the
rename-test-steps
branch
from
469a85d to
cfd3cee
Compare
|
☔ The latest upstream changes (presumably #135172) made this pull request unmergeable. Please resolve the merge conflicts. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2025
bootstrap: Add more comments to some of the test steps Some of the test steps have names that don't clearly indicate what they actually do. While there is ongoing experimental work to actually rename the steps (e.g. rust-lang#135071), that's dependent on figuring out what the new names should actually be. In the meantime, we can still improve things by adding comments to help describe the steps, which will remain useful even after any renaming.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 9, 2025
bootstrap: Add more comments to some of the test steps Some of the test steps have names that don't clearly indicate what they actually do. While there is ongoing experimental work to actually rename the steps (e.g. rust-lang#135071), that's dependent on figuring out what the new names should actually be. In the meantime, we can still improve things by adding comments to help describe the steps, which will remain useful even after any renaming.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2025
Rollup merge of rust-lang#135231 - Zalathar:test-step-notes, r=jieyouxu bootstrap: Add more comments to some of the test steps Some of the test steps have names that don't clearly indicate what they actually do. While there is ongoing experimental work to actually rename the steps (e.g. rust-lang#135071), that's dependent on figuring out what the new names should actually be. In the meantime, we can still improve things by adding comments to help describe the steps, which will remain useful even after any renaming.
|
@rustbot author |
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this does a better job of helping contributors understand what each step does, at a glance.
Original Zulip thread