mark deprecated option as deprecated in rustc_session to remove copypasta and small refactor #135126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
klensy
commented
Jan 5, 2025
| @@ -1128,10 +1128,6 @@ pub fn describe_flag_categories(early_dcx: &EarlyDiagCtxt, matches: &Matches) -> | |||
| early_dcx.early_warn("the `-Cno-stack-check` flag is deprecated and does nothing"); | |||
| } | |||
|
|
|||
| if cg_flags.iter().any(|x| x.starts_with("inline-threshold")) { | |||
There was a problem hiding this comment.
Previously this have ability to warn for any possible flags with inline-threshold prefix, but not now.
This comment has been minimized.
This comment has been minimized.
klensy
force-pushed
the
deprecated-and-do-nothing
branch
from
38b67bb to
43f73c0
Compare
This comment has been minimized.
This comment has been minimized.
klensy
force-pushed
the
deprecated-and-do-nothing
branch
from
43f73c0 to
080174e
Compare
jieyouxu
reviewed
Jan 5, 2025
jieyouxu
added
S-waiting-on-author
klensy
force-pushed
the
deprecated-and-do-nothing
branch
from
069d2a2 to
da80a6b
Compare
jieyouxu
approved these changes
Jan 6, 2025
|
@bors delegate+ rollup |
inline_threshold mark deprecated no-stack-check print deprecation message for -Car too inline_threshold deprecated and do nothing: make in untracked make OptionDesc struct from tuple
klensy
force-pushed
the
deprecated-and-do-nothing
branch
from
da80a6b to
37f2631
Compare
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jan 7, 2025
…r=jieyouxu mark deprecated option as deprecated in rustc_session to remove copypasta and small refactor This marks deprecated options as deprecated via flag in options table in rustc_session, which removes copypasted deprecation text from rustc_driver_impl. This also adds warning for deprecated `-C ar` option, which didn't emitted any warnings before. Makes `inline_threshold` `[UNTRACKED]`, as it do nothing. Adds few tests. See individual commits.
This was referenced Jan 7, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 7, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#131830 (Add support for wasm exception handling to Emscripten target) - rust-lang#132345 (Improve diagnostics for `HostEffectPredicate` in the new solver) - rust-lang#134568 (Release notes for 1.84.0) - rust-lang#134744 (Don't ice on bad transmute in typeck in new solver) - rust-lang#135090 (Suggest to replace tuple constructor through projection) - rust-lang#135116 (rustdoc: Fix mismatched capitalization in sidebar) - rust-lang#135126 (mark deprecated option as deprecated in rustc_session to remove copypasta and small refactor) - rust-lang#135139 ([generic_assert] Constify methods used by the formatting system) - rust-lang#135170 (Update triagebot.toml: celinval vacation is over) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 7, 2025
Rollup merge of rust-lang#135126 - klensy:deprecated-and-do-nothing, r=jieyouxu mark deprecated option as deprecated in rustc_session to remove copypasta and small refactor This marks deprecated options as deprecated via flag in options table in rustc_session, which removes copypasted deprecation text from rustc_driver_impl. This also adds warning for deprecated `-C ar` option, which didn't emitted any warnings before. Makes `inline_threshold` `[UNTRACKED]`, as it do nothing. Adds few tests. See individual commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks deprecated options as deprecated via flag in options table in rustc_session, which removes copypasted deprecation text from rustc_driver_impl.
This also adds warning for deprecated
-C aroption, which didn't emitted any warnings before.Makes
inline_threshold[UNTRACKED], as it do nothing.Adds few tests.
See individual commits.