Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve x18 register for aarch64 wrs vxworks target #135184

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

biabbas
Copy link
Contributor

@biabbas biabbas commented Jan 7, 2025

Fixes #135166
r? @workingjubilee

Regards,
B I Abbas

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2025

Could not assign reviewer from: workingjubilee.
User(s) workingjubilee are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@workingjubilee
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 7, 2025

📌 Commit af15e04 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2025
…ingjubilee

Reserve x18 register for aarch64 wrs vxworks target

Fixes rust-lang#135166
r? `@workingjubilee`

Regards,
B I Abbas
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#134389 (Condvar: implement wait_timeout for targets without threads)
 - rust-lang#134920 (Convert typeck constraints in location-sensitive polonius)
 - rust-lang#135032 (triagebot: register `relnotes-interest-group` ping group)
 - rust-lang#135176 (More compelling env_clear() examples)
 - rust-lang#135184 (Reserve x18 register for aarch64 wrs vxworks target)
 - rust-lang#135203 (arm: add unstable soft-float target feature)
 - rust-lang#135219 (warn about broken simd not only on structs but also enums and unions when we didn't opt in to it)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2025
Rollup of 7 pull requests

Successful merges:

 - rust-lang#134389 (Condvar: implement wait_timeout for targets without threads)
 - rust-lang#134920 (Convert typeck constraints in location-sensitive polonius)
 - rust-lang#135032 (triagebot: register `relnotes-interest-group` ping group)
 - rust-lang#135176 (More compelling env_clear() examples)
 - rust-lang#135184 (Reserve x18 register for aarch64 wrs vxworks target)
 - rust-lang#135203 (arm: add unstable soft-float target feature)
 - rust-lang#135219 (warn about broken simd not only on structs but also enums and unions when we didn't opt in to it)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: i686-mingw
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang#133057 (Impl String::into_chars)
 - rust-lang#134389 (Condvar: implement wait_timeout for targets without threads)
 - rust-lang#134920 (Convert typeck constraints in location-sensitive polonius)
 - rust-lang#135032 (triagebot: register `relnotes-interest-group` ping group)
 - rust-lang#135176 (More compelling env_clear() examples)
 - rust-lang#135184 (Reserve x18 register for aarch64 wrs vxworks target)
 - rust-lang#135203 (arm: add unstable soft-float target feature)
 - rust-lang#135219 (warn about broken simd not only on structs but also enums and unions when we didn't opt in to it)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 45250f3 into rust-lang:master Jan 8, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 8, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2025
Rollup merge of rust-lang#135184 - biabbas:reserve_18_aarch64, r=workingjubilee

Reserve x18 register for aarch64 wrs vxworks target

Fixes rust-lang#135166
r? ``@workingjubilee``

Regards,
B I Abbas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AArch64 register X18 is reserved for a platform register on VxWorks
5 participants