rustdoc-json: Include items in stripped modules in Crate::paths.
#135348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-rustdoc-json
rust-cloud-vms
bot
force-pushed
the
pathspathspaths
branch
from
0131c49 to
b1c97aa
Compare
src/tools/jsondocck/src/main.rs
Outdated
| @@ -65,6 +65,11 @@ enum CommandKind { | |||
| /// Checks the path doesn't exist. | |||
| HasNotPath, | |||
|
|
|||
| /// `//@ !has <path> <value>` | |||
| /// | |||
| /// Checks the path doesn't exist. | |||
There was a problem hiding this comment.
Isn't it supposed to check that the path exists but doesn't have this value?
There was a problem hiding this comment.
D'oh! Copy & Paste error. Fixed.
Also, I like your idea of checking the path does exist. I've added that.
rust-cloud-vms
bot
force-pushed
the
pathspathspaths
branch
from
b1c97aa to
24d453e
Compare
This was removed for not being used [1], but now we need it. [1]: rust-lang#133478 (comment)
rust-cloud-vms
bot
force-pushed
the
pathspathspaths
branch
from
24d453e to
2a2b090
Compare
GuillaumeGomez
approved these changes
Jan 12, 2025
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 12, 2025
…uillaumeGomez rustdoc-json: Include items in stripped modules in `Crate::paths`. Closes rust-lang#135309 When we're running rustdoc-json, we should err on the side of adding more items to `Cache::paths`, as that directly becomes `Crate::paths` in the output. r? `@GuillaumeGomez.` Best reviewed commit-by-commit.
This was referenced Jan 12, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2025
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#135348 (rustdoc-json: Include items in stripped modules in `Crate::paths`.) - rust-lang#135365 (Update the explanation for why we use box_new in vec!) - rust-lang#135383 (De-abstract tagged ptr and make it covariant) - rust-lang#135401 (Remove some empty expected files to fix blessing) - rust-lang#135406 (Update unstable lint docs to include required feature attributes) - rust-lang#135407 (Deny various clippy lints) - rust-lang#135411 (run_make_support: add `#![warn(unreachable_pub)]`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 13, 2025
Rollup merge of rust-lang#135348 - aDotInTheVoid:pathspathspaths, r=GuillaumeGomez rustdoc-json: Include items in stripped modules in `Crate::paths`. Closes rust-lang#135309 When we're running rustdoc-json, we should err on the side of adding more items to `Cache::paths`, as that directly becomes `Crate::paths` in the output. r? ``@GuillaumeGomez.`` Best reviewed commit-by-commit.
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#135348 (rustdoc-json: Include items in stripped modules in `Crate::paths`.) - rust-lang#135365 (Update the explanation for why we use box_new in vec!) - rust-lang#135383 (De-abstract tagged ptr and make it covariant) - rust-lang#135401 (Remove some empty expected files to fix blessing) - rust-lang#135406 (Update unstable lint docs to include required feature attributes) - rust-lang#135407 (Deny various clippy lints) - rust-lang#135411 (run_make_support: add `#![warn(unreachable_pub)]`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135309
When we're running rustdoc-json, we should err on the side of adding more items to
Cache::paths, as that directly becomesCrate::pathsin the output.r? @GuillaumeGomez. Best reviewed commit-by-commit.