Skip to content

use a single large catch_unwind in lang_start #135359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

RalfJung
Copy link
Member

I originally planned to use abort_unwind but reading the comment in thread_cleanup it seems we are deliberately going for slightly nicer error messages here, so this preserves that. It still seems nice to not repeat catch_unwind so often.

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 11, 2025
@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2025

The Miri subtree was changed

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

@RalfJung RalfJung force-pushed the lang-start-unwind branch 2 times, most recently from 05993b3 to 1cbc770 Compare January 11, 2025 14:45
@RalfJung RalfJung force-pushed the lang-start-unwind branch 3 times, most recently from ce014fd to daabd2b Compare January 11, 2025 14:52
@joboet
Copy link
Member

joboet commented Jan 13, 2025

Sounds good.
@bors r+
r? joboet

@bors
Copy link
Collaborator

bors commented Jan 13, 2025

📌 Commit 471d830 has been approved by joboet

It is now in the queue for this repository.

@rustbot rustbot assigned joboet and unassigned ibraheemdev Jan 13, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2025
@bors
Copy link
Collaborator

bors commented Jan 14, 2025

⌛ Testing commit 471d830 with merge e491cae...

@bors
Copy link
Collaborator

bors commented Jan 14, 2025

☀️ Test successful - checks-actions
Approved by: joboet
Pushing e491cae to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 14, 2025
@bors bors merged commit e491cae into rust-lang:master Jan 14, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 14, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e491cae): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.3% [-0.7%, -0.1%] 6
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 4.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.4% [4.4%, 4.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.4% [4.4%, 4.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 764.65s -> 764.175s (-0.06%)
Artifact size: 326.06 MiB -> 326.11 MiB (0.02%)

@RalfJung RalfJung deleted the lang-start-unwind branch January 14, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants