-
Notifications
You must be signed in to change notification settings - Fork 13.6k
use a single large catch_unwind in lang_start #135359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
bde2cbf
to
4215c1c
Compare
This comment has been minimized.
This comment has been minimized.
4215c1c
to
a8ee8dc
Compare
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
05993b3
to
1cbc770
Compare
ce014fd
to
daabd2b
Compare
daabd2b
to
471d830
Compare
Sounds good. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e491cae): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 4.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 764.65s -> 764.175s (-0.06%) |
I originally planned to use
abort_unwind
but reading the comment inthread_cleanup
it seems we are deliberately going for slightly nicer error messages here, so this preserves that. It still seems nice to not repeatcatch_unwind
so often.