-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove allocations from case-insensitive comparison to keywords #135371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…=<try> Remove allocations from case-insensitive comparison to keywords Follows up on work in 99d02fb, expanding the alloc-free comparisons to more cases of case-insensitive keyword matching. r? ghost for perf
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (669e151): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 763.38s -> 761.414s (-0.26%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a good change regardless
r=me if you still want to land this |
@bors r=compiler-errors I think it's good to be uniform and I did see instruction count wins (probably below our noise thresholds) on a local benchmark (from https://scot.tg/2025/01/07/no-op-compiler-benchmarking/). |
…=compiler-errors Remove allocations from case-insensitive comparison to keywords Follows up on work in 99d02fb, expanding the alloc-free comparisons to more cases of case-insensitive keyword matching. r? ghost for perf
💔 Test failed - checks-actions |
unrelated? @bors retry rollup=maybe |
… r=compiler-errors Remove allocations from case-insensitive comparison to keywords Follows up on work in 99d02fb, expanding the alloc-free comparisons to more cases of case-insensitive keyword matching. r? ghost for perf
☀️ Test successful - checks-actions |
Finished benchmarking commit (047bc17): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 765.014s -> 763.719s (-0.17%) |
Follows up on work in 99d02fb, expanding the alloc-free comparisons to more cases of case-insensitive keyword matching.
r? ghost for perf