Skip to content

Remove allocations from case-insensitive comparison to keywords #135371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Mark-Simulacrum
Copy link
Member

Follows up on work in 99d02fb, expanding the alloc-free comparisons to more cases of case-insensitive keyword matching.

r? ghost for perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2025
@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 11, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2025
…=<try>

Remove allocations from case-insensitive comparison to keywords

Follows up on work in 99d02fb, expanding the alloc-free comparisons to more cases of case-insensitive keyword matching.

r? ghost for perf
@bors
Copy link
Collaborator

bors commented Jan 11, 2025

⌛ Trying commit 6f72f13 with merge 669e151...

@bors
Copy link
Collaborator

bors commented Jan 11, 2025

☀️ Try build successful - checks-actions
Build commit: 669e151 (669e151c029eb2c311f752e72df3ca080a935669)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (669e151): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.8% [-0.8%, -0.8%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 763.38s -> 761.414s (-0.26%)
Artifact size: 326.03 MiB -> 326.05 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 11, 2025
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a good change regardless

@compiler-errors
Copy link
Member

r=me if you still want to land this

@Mark-Simulacrum
Copy link
Member Author

@bors r=compiler-errors

I think it's good to be uniform and I did see instruction count wins (probably below our noise thresholds) on a local benchmark (from https://scot.tg/2025/01/07/no-op-compiler-benchmarking/).

@bors
Copy link
Collaborator

bors commented Jan 11, 2025

📌 Commit 6f72f13 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2025
@bors
Copy link
Collaborator

bors commented Jan 12, 2025

⌛ Testing commit 6f72f13 with merge 89709ec...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2025
…=compiler-errors

Remove allocations from case-insensitive comparison to keywords

Follows up on work in 99d02fb, expanding the alloc-free comparisons to more cases of case-insensitive keyword matching.

r? ghost for perf
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Jan 12, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2025
@compiler-errors
Copy link
Member

unrelated?

@bors retry rollup=maybe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 12, 2025
… r=compiler-errors

Remove allocations from case-insensitive comparison to keywords

Follows up on work in 99d02fb, expanding the alloc-free comparisons to more cases of case-insensitive keyword matching.

r? ghost for perf
@bors
Copy link
Collaborator

bors commented Jan 13, 2025

⌛ Testing commit 6f72f13 with merge 047bc17...

@bors
Copy link
Collaborator

bors commented Jan 13, 2025

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 047bc17 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 13, 2025
@bors bors merged commit 047bc17 into rust-lang:master Jan 13, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 13, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (047bc17): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [-2.9%, 3.4%] 2

Cycles

Results (secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 765.014s -> 763.719s (-0.17%)
Artifact size: 326.06 MiB -> 326.09 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants