-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement partial capturing of types in use<...>
#135765
Implement partial capturing of types in use<...>
#135765
Conversation
i'd expect this to 1) be non-trivial and 2) to definitely land behind a feature gate at first. Handing it over to errs as they should hopefully know more about why this was not supported right away. |
The job Click to see the possible cause of the failure (guessed by this bot)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does not actually demonstrate that this functionality works at all. It's not gated behind a new feature gate, and also does not address fundamental problems with how bivariance/uncapturedness of type parameters works. It does not exercise how this interacts with type outlives, the equality of opaque types modulo uncaptured parameters, nor does this exercise how this behaves on uncaptured const parameters.
@frank-king: I highly recommend implementing features that you are confident how to implement, especially when it comes to the type system. Otherwise, you're giving work to others to have to explain why your implementation is not correct.
Gonna close this for now. |
This PR implements #130043. It loses the requirement that all type and const params be mentioned in the
use<...>
list. Now only used type and const params should be mentioned.