Skip to content

Replace all ~"" with "".to_owned() #13607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2014
Merged

Replace all ~"" with "".to_owned() #13607

merged 1 commit into from
Apr 19, 2014

Conversation

brson
Copy link
Contributor

@brson brson commented Apr 18, 2014

Continues #13548

bors added a commit that referenced this pull request Apr 18, 2014
@richo
Copy link
Contributor

richo commented Apr 19, 2014

Are the task '<unnamed>' failed at 'receiving on a closed channel', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/libstd/comm/mod.rs:733 Messages something I broke? I've never seen that error.

@richo
Copy link
Contributor

richo commented Apr 19, 2014

i just bumped this branch. I fixed the site where it failed, but because the test suite bails early it's possible other non-darwin parts got missed.

Appreciate either rebasing this branch on master again, or some thoughts on how I can guarantee that this will work without wasting more of your time :)

@brson
Copy link
Contributor Author

brson commented Apr 19, 2014

@richo The task failure is probably fine - there are lots of tests that are simply testing failure scenarios. I also fixed that error and repushed. I'll keep retrying until it lands. I'll run the test suite here on linux in the meantime to see if there's anything lurking there. This should land pretty fast. Sometimes it just takes a few tries.

@richo
Copy link
Contributor

richo commented Apr 19, 2014

Yeah, I was quick to comment before I properly read the code and saw the should_fail annotation.

Thanks again for all your help on this! I'll be around if I can do anything to help.

bors added a commit that referenced this pull request Apr 19, 2014
@bors bors closed this Apr 19, 2014
@bors bors merged commit 919889a into rust-lang:master Apr 19, 2014
@brson
Copy link
Contributor Author

brson commented Apr 19, 2014

\o/ Nice work @richo!

@richo
Copy link
Contributor

richo commented Apr 19, 2014

\o/

matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Nov 16, 2022
internal: Add version info to unsupported proc macro abi error

cc rust-lang/rust-analyzer#13589 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants