-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow multiple suggestions for malformed crate_type attribute #136125
base: master
Are you sure you want to change the base?
feat: allow multiple suggestions for malformed crate_type attribute #136125
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer Some changes occurred in src/tools/cargo cc @ehuss |
src/tools/rust-analyzer/crates/hir-expand/src/inert_attr_macro.rs
Outdated
Show resolved
Hide resolved
Please
from this PR @rustbot author |
a3070a3
to
d924bea
Compare
This comment has been minimized.
This comment has been minimized.
@Blindspot22: I'll review again once the comments from @oli-obk are addressed and CI tests are passing. |
☔ The latest upstream changes (presumably #136225) made this pull request unmergeable. Please resolve the merge conflicts. |
Solves this #130923 from these #61288
Hello @nnethercote check here