rustdoc: Display tuple structs correctly #13639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this break support for "internal" docs builds that don't want privacy stripping? |
|
It will break support for public/private struct fields, yes, but not for other kinds of privacy stripping. |
|
It seems like we should make "should this be rendered" a separate concept from visibility inside of rustdoc. Most of the time they'd be the same, but it'd give the flexibility for callers to disable the privacy pass and get internal docs. |
The fields of tuple structs recently gained the ability to have privacy associated with them, but rustdoc was not updated accodingly. This moves the struct field filtering to the rendering phase in order to preserve the ordering of struct fields to allow tuple structs to have their private fields printed as underscores. Closes rust-lang#13594
|
Moved stripping back into |
bors
added a commit
that referenced
this pull request
Apr 20, 2014
…kler The fields of tuple structs recently gained the ability to have privacy associated with them, but rustdoc was not updated accodingly. This moves the struct field filtering to the rendering phase in order to preserve the ordering of struct fields to allow tuple structs to have their private fields printed as underscores. Closes #13594
Manishearth
pushed a commit
to Manishearth/rust
that referenced
this pull request
Nov 23, 2022
fix: Fix proc-macro-srv search paths for Arch Linux Fixes rust-lang/rust-analyzer#13616
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields of tuple structs recently gained the ability to have privacy
associated with them, but rustdoc was not updated accodingly. This moves the
struct field filtering to the rendering phase in order to preserve the ordering
of struct fields to allow tuple structs to have their private fields printed as
underscores.
Closes #13594