Fix diagnostic when using = instead of : in let binding #136869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
jieyouxu
reviewed
Feb 11, 2025
estebank
reviewed
Feb 11, 2025
Comment on lines
2376
to
2380
| if err.code == Some(E0423) | ||
| && let Some((let_span, _, _)) = self.diag_metadata.current_let_binding | ||
| && let span = let_span.shrink_to_hi().to(ident_span.shrink_to_lo()) | ||
| && let Ok(code) = self.r.tcx.sess.source_map().span_to_snippet(span) | ||
| && code.trim() == "=" |
There was a problem hiding this comment.
Is there no alternative way of doing this? We don't have info on the expression/AST node? Wouldn't self.diag_metadata.current_let_binding.2 point at the space after the =, which could be compared against the span you already have?
There was a problem hiding this comment.
you means checking the ident_span is starting point of current_let_binding.2.span?
I updated the code.
chenyukang
force-pushed
the
yukang-fix-133713-let-binding
branch
from
fc05d76 to
86548fc
Compare
chenyukang
force-pushed
the
yukang-fix-133713-let-binding
branch
from
86548fc to
a917fd5
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Feb 14, 2025
…inding, r=estebank Fix diagnostic when using = instead of : in let binding Fixes rust-lang#133713 r? `@estebank`
This was referenced Feb 14, 2025
|
sequences with another PR @bors p=1 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 14, 2025
…kingjubilee Rollup of 11 pull requests Successful merges: - rust-lang#136863 (rework rigid alias handling ) - rust-lang#136869 (Fix diagnostic when using = instead of : in let binding) - rust-lang#136895 (debuginfo: Set bitwidth appropriately in enum variant tags) - rust-lang#136928 (eagerly prove WF when resolving fully qualified paths) - rust-lang#136941 (Move `llvm.ccache` to `build.ccache`) - rust-lang#136950 (rustdoc: use better, consistent SVG icons for scraped examples) - rust-lang#136957 (coverage: Eliminate more counters by giving them to unreachable nodes) - rust-lang#136960 (Compiletest should not inherit all host RUSTFLAGS) - rust-lang#136962 (unify LLVM version finding logic) - rust-lang#136970 (ci: move `x86_64-gnu-debug` job to the free runner) - rust-lang#136973 (Fix `x test --stage 1 ui-fulldeps` on macOS (until the next beta bump)) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 14, 2025
Rollup merge of rust-lang#136869 - chenyukang:yukang-fix-133713-let-binding, r=estebank Fix diagnostic when using = instead of : in let binding Fixes rust-lang#133713 r? ``@estebank``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133713
r? @estebank