Add support for 64-bit Windows builds #13692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work, nice job! Have you had much luck with backtraces? |
|
backtrace won't work in this version, because it requires stack unwinding. Once LLVM SEH patch is added, it works, however you don't get any symbols, because dbghelp.dll doesn't know how to use DWARF debug info. |
|
better? |
bors
added a commit
that referenced
this pull request
Apr 23, 2014
Stack unwinding doesn't work yet, so this won't pass a lot of tests.
Closed
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 9, 2025
… comments (rust-lang#13911) Fixes rust-lang#13692. If the `vec!` macro call contains comments, we should not provide suggestions and let users handle it however they see fit. changelog: Only emit `useless_vec` suggestion if the macro does not contain code comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack unwinding doesn't work yet, so this won't pass a lot of tests.