Cleaned up os::consts #13697
Closed
Cleaned up os::consts #13697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| #[cfg(target_arch = "mips")] | ||
| pub mod arch_consts { | ||
| pub static ARCH: &'static str = "mips"; | ||
| } |
There was a problem hiding this comment.
Instead of having a separate module for arch_consts, perhaps we could reexport under the same module?
#[cfg(target_os = "relevant-platform")]
pub mod consts {
pub use os::arch_consts::ARCH;
// ...
}
#[cfg(target_arch = "relevant-arch")]
mod arch_consts {
pub static ARCH: &'static str = "foo";
}
|
@alexcrichton Fixed! |
|
Looks good to me! Just one minor nit, and could you tweak the commit message in accordance with our new breaking change policy? It doesn't need to be too long, but this will break any existing code relying on the previous structure of |
|
It seems I am having git problems. The tests should work now though, fixing. |
|
Hm, this seems to have picked up a few extra commits. If you do |
…et OS and arch. Constants for other OS's and arch's must be defined manually. [breaking-change]
|
@alexcrichton This should work now. Thanks! |
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Dec 17, 2022
…solve-data, r=jonas-schievink internal: Version the inlay hint resolve data cc rust-lang/rust-analyzer#13657 cc rust-lang/rust-analyzer#13372 cc rust-lang/rust-analyzer#13170 This will make us log an error and return the unmodified inlay hints when the client attempts to resolve inlay hints in a file that has since been modified.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 20, 2025
Closes rust-lang#13697. --- changelog: add [`owned_cow`] lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to put architecture constants in another mod. They are not used, so a part of me is thinking of just getting rid of them altogether. The rest should be similar to what @brson wants.
Fixes #13536