Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken x {doc, build} core #137119

Merged
merged 1 commit into from
Feb 17, 2025
Merged

fix broken x {doc, build} core #137119

merged 1 commit into from
Feb 17, 2025

Conversation

onur-ozkan
Copy link
Member

Fixes #137115

@onur-ozkan
fix broken x {doc, build} core
56f8f48 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 16, 2025
Shourya742
Shourya742 approved these changes Feb 16, 2025
View reviewed changes
Copy link
Contributor

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 56f8f48

@jieyouxu
Copy link
Member

r? jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned Mark-Simulacrum Feb 16, 2025
jieyouxu
jieyouxu approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, also tested locally, seems to behave as expected.

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 16, 2025

📌 Commit 56f8f48 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 16, 2025
@matthiaskrgr
Rollup merge of rust-lang#137119 - onur-ozkan:fix-broken-core, r=jiey…
29e62d4 
…ouxu

fix broken `x {doc, build} core`

Fixes rust-lang#137115
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 16, 2025
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 16, 2025
@GuillaumeGomez
Rollup merge of rust-lang#137119 - onur-ozkan:fix-broken-core, r=jiey…
0a867e6 
…ouxu

fix broken `x {doc, build} core`

Fixes rust-lang#137115
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 16, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2025
@bors
Auto merge of rust-lang#137124 - matthiaskrgr:rollup-0yymflu, r=matth…
fffb33d 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#125087 (Optimize `Seek::stream_len` impl for `File`)
 - rust-lang#136986 (Apply unsafe_op_in_unsafe_fn to the standard library)
 - rust-lang#137012 (add docs and ut for bootstrap util cc-detect)
 - rust-lang#137072 (Load all builtin targets at once instead of one by one in check-cfg)
 - rust-lang#137102 (Rework `name_regions` to not rely on reverse scc graph for non-member-constrain usages)
 - rust-lang#137112 (Don't project into `NonNull` when dropping a `Box`)
 - rust-lang#137114 (Add an example for `std::error::Error`)
 - rust-lang#137117 (Fix test that relies on error language)
 - rust-lang#137119 (fix broken `x {doc, build} core`)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 16, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2025
@bors
Auto merge of rust-lang#137143 - matthiaskrgr:rollup-9hapmyd, r=matth…
d1fb81e 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136986 (Apply unsafe_op_in_unsafe_fn to the standard library)
 - rust-lang#137012 (add docs and ut for bootstrap util cc-detect)
 - rust-lang#137072 (Load all builtin targets at once instead of one by one in check-cfg)
 - rust-lang#137102 (Rework `name_regions` to not rely on reverse scc graph for non-member-constrain usages)
 - rust-lang#137112 (Don't project into `NonNull` when dropping a `Box`)
 - rust-lang#137114 (Add an example for `std::error::Error`)
 - rust-lang#137117 (Fix test that relies on error language)
 - rust-lang#137119 (fix broken `x {doc, build} core`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e802a8c into rust-lang:master Feb 17, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 17, 2025
@rust-timer
Unrolled build for rust-lang#137119
8e3ec2c 
Rollup merge of rust-lang#137119 - onur-ozkan:fix-broken-core, r=jieyouxu

fix broken `x {doc, build} core`

Fixes rust-lang#137115
@rustbot rustbot added this to the 1.87.0 milestone Feb 17, 2025
@onur-ozkan onur-ozkan deleted the fix-broken-core branch February 17, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

@Shourya742 Shourya742 Shourya742 approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

./x doc core doesn't work
6 participants
@onur-ozkan @rustbot @jieyouxu @bors @Shourya742 @Mark-Simulacrum