Don't store a redundant span in user-type projections

[Zalathar]

While experimenting with some larger changes, I noticed that storing this span here is unnecessary, because it is also present in the corresponding CanonicalUserTypeAnnotation and can be retrieved via the annotation's ID.

[rustbot]

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[oli-obk]

@bors try @rust-timer queue

r? @oli-obk

[bors]

⌛ Trying commit 9f3fdb1 with merge aa2aeba...

[bors]

☀️ Try build successful - checks-actions
Build commit: aa2aeba (aa2aebab0f94a5f20d5ed31ac943f85b6335ec88)

[rust-timer]

Finished benchmarking commit (aa2aeba): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.3%, -0.2%]	4
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	6
All ❌✅ (primary)	-0.2%	[-0.3%, -0.2%]	4

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 4.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.9%	[4.9%, 4.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 790.759s -> 787.867s (-0.37%)
Artifact size: 350.03 MiB -> 350.00 MiB (-0.01%)

[oli-obk]

r? @oli-obk

@bors r+

[bors]

📌 Commit 9f3fdb1 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9f3fdb1 with merge ec7f149...

[bors]

💔 Test failed - checks-actions

[oli-obk]

@bors retry temp for failure on windows

[bors]

☔ The latest upstream changes (presumably #137295) made this pull request unmergeable. Please resolve the merge conflicts.

[Zalathar]

Rebased over #137266; no changes.

@bors r=oli-obk

[bors]

📌 Commit ffaf825 has been approved by oli-obk

It is now in the queue for this repository.

[Zalathar]

Actually, I'm going to back out the visitor changes, as I'm no longer confident in them, and they aren't strictly necessary for the other changes.

@bors r-

[Zalathar]

PR CI is green; I'm going to unilaterally re-approve this because it's a subset of the changes that were originally approved.

@bors r=oli-obk

[bors]

📌 Commit 8bb574f has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8bb574f with merge 28b83ee...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 28b83ee to master...

[rust-timer]

Finished benchmarking commit (28b83ee): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.0%	[1.6%, 2.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[1.6%, 2.3%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.474s -> 774.026s (0.07%)
Artifact size: 360.26 MiB -> 360.27 MiB (0.00%)