Skip to content

Conversation

epage
Copy link
Contributor

@epage epage commented Feb 18, 2025

features_untracked was removed in #114723

features are now functions as of #132027

@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix the commit and then r=me

@epage epage force-pushed the features_untracked branch from 16f1baa to 5e92241 Compare February 18, 2025 16:36
@epage epage changed the title docs(dev): Remove reference to features_untracked docs(dev): Update the feature-gate instructions Feb 18, 2025
@epage
Copy link
Contributor Author

epage commented Feb 18, 2025

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Feb 18, 2025

📌 Commit 5e92241 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 18, 2025
…er-errors

docs(dev): Update the feature-gate instructions

`features_untracked` was removed in rust-lang#114723

features are now functions as of  rust-lang#132027
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 18, 2025
…er-errors

docs(dev): Update the feature-gate instructions

`features_untracked` was removed in rust-lang#114723

features are now functions as of  rust-lang#132027
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#127793 (Added project-specific Zed IDE settings)
 - rust-lang#132268 (Impl TryFrom<Vec<u8>> for String)
 - rust-lang#134995 (Stabilize const_slice_flatten)
 - rust-lang#136985 (Do not ignore uninhabited types for function-call ABI purposes. (Remove BackendRepr::Uninhabited))
 - rust-lang#137155 (Organize `OsString`/`OsStr` shims)
 - rust-lang#137227 (docs(dev): Update the feature-gate instructions)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2025
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#127793 (Added project-specific Zed IDE settings)
 - rust-lang#134995 (Stabilize const_slice_flatten)
 - rust-lang#136301 (Improve instant docs)
 - rust-lang#136347 (Add a bullet point to `std::fs::copy`)
 - rust-lang#136794 (Stabilize file_lock)
 - rust-lang#137094 (x86_win64 ABI: do not use xmm0 with softfloat ABI)
 - rust-lang#137227 (docs(dev): Update the feature-gate instructions)
 - rust-lang#137232 (Don't mention `FromResidual` on bad `?`)
 - rust-lang#137251 (coverage: Get hole spans from nested items without fully visiting them)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fa10786 into rust-lang:master Feb 19, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 19, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2025
Rollup merge of rust-lang#137227 - epage:features_untracked, r=compiler-errors

docs(dev): Update the feature-gate instructions

`features_untracked` was removed in rust-lang#114723

features are now functions as of  rust-lang#132027
@epage epage deleted the features_untracked branch February 20, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants