Skip to content

Move methods from Map to TyCtxt, part 3. #137350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2025
Merged

Move methods from Map to TyCtxt, part 3. #137350

merged 2 commits into from
Feb 21, 2025

Conversation

@nnethercote
Copy link
Contributor

A follow-up to #137162.

r? @Zalathar

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2025

HIR ty lowering was modified

cc @fmease

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nnethercote
Move methods from Map to TyCtxt, part 3.
806be25 
Continuing the work from rust-lang#137162.

Every method gains a `hir_` prefix.
@Zalathar
Copy link
Contributor

Phew, that's a lot of trivial changes!

r=me when PR CI is green.

@nnethercote
Copy link
Contributor Author

Thanks for the fast review.

@bors r=Zalathar

@bors
Copy link
Collaborator

bors commented Feb 21, 2025

📌 Commit 806be25 has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 21, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2025
@bors
Auto merge of rust-lang#137397 - matthiaskrgr:rollup-ls2pilo, r=matth…
794c124 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#132876 (rustdoc book: acknowledge --document-hidden-items)
 - rust-lang#136148 (Optionally add type names to `TypeId`s.)
 - rust-lang#136609 (libcore/net: `IpAddr::as_octets()`)
 - rust-lang#137336 (Stabilise `os_str_display`)
 - rust-lang#137350 (Move methods from Map to TyCtxt, part 3.)
 - rust-lang#137353 (Implement `read_buf` for WASI stdin)
 - rust-lang#137361 (Refactor `OperandRef::extract_field` to prep for MCP838)
 - rust-lang#137367 (Do not exempt nonexistent platforms from platform policy)
 - rust-lang#137374 (Stacker now handles miri using a noop impl itself)
 - rust-lang#137392 (remove few unused fields)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a24eb0b into rust-lang:master Feb 21, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 21, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2025
@rust-timer
Unrolled build for rust-lang#137350
e3b7a84 
Rollup merge of rust-lang#137350 - nnethercote:remove-Map-3, r=Zalathar

Move methods from Map to TyCtxt, part 3.

A follow-up to rust-lang#137162.

r? `@Zalathar`
@nnethercote nnethercote deleted the remove-Map-3 branch February 23, 2025 21:25
nnethercote added a commit to nnethercote/rust that referenced this pull request Feb 24, 2025
@nnethercote
Move methods from Map to TyCtxt, part 4.
4bdbebd 
Continuing the work from rust-lang#137350.

Removes the unused methods: `expect_variant`, `expect_field`,
`expect_foreign_item`.

Every method gains a `hir_` prefix.
@nnethercote nnethercote mentioned this pull request Feb 24, 2025
Merged
nnethercote added a commit to nnethercote/rust that referenced this pull request Feb 25, 2025
@nnethercote
Move methods from Map to TyCtxt, part 4.
8207838 
Continuing the work from rust-lang#137350.

Removes the unused methods: `expect_variant`, `expect_field`,
`expect_foreign_item`.

Every method gains a `hir_` prefix.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 27, 2025
@bors
Auto merge of rust-lang#137397 - matthiaskrgr:rollup-ls2pilo, r=matth…
49082f9 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#132876 (rustdoc book: acknowledge --document-hidden-items)
 - rust-lang#136148 (Optionally add type names to `TypeId`s.)
 - rust-lang#136609 (libcore/net: `IpAddr::as_octets()`)
 - rust-lang#137336 (Stabilise `os_str_display`)
 - rust-lang#137350 (Move methods from Map to TyCtxt, part 3.)
 - rust-lang#137353 (Implement `read_buf` for WASI stdin)
 - rust-lang#137361 (Refactor `OperandRef::extract_field` to prep for MCP838)
 - rust-lang#137367 (Do not exempt nonexistent platforms from platform policy)
 - rust-lang#137374 (Stacker now handles miri using a noop impl itself)
 - rust-lang#137392 (remove few unused fields)

r? `@ghost`
`@rustbot` modify labels: rollup
nnethercote added a commit to nnethercote/rust that referenced this pull request Mar 4, 2025
@nnethercote
Move methods from Map to TyCtxt, part 4.
89c6c61 
Continuing the work from rust-lang#137350.

Removes the unused methods: `expect_variant`, `expect_field`,
`expect_foreign_item`.

Every method gains a `hir_` prefix.
nnethercote added a commit to nnethercote/rust that referenced this pull request Mar 4, 2025
@nnethercote
Move methods from Map to TyCtxt, part 4.
1047768 
Continuing the work from rust-lang#137350.

Removes the unused methods: `expect_variant`, `expect_field`,
`expect_foreign_item`.

Every method gains a `hir_` prefix.
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 11, 2025
@jieyouxu
Rollup merge of rust-lang#137504 - nnethercote:remove-Map-4, r=Zalathar
4c3d606 
Move methods from Map to TyCtxt, part 4.

A follow-up to rust-lang#137350.

r? `@Zalathar`
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
@bors
Auto merge of rust-lang#137397 - matthiaskrgr:rollup-ls2pilo, r=matth…
1a4ad2c 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#132876 (rustdoc book: acknowledge --document-hidden-items)
 - rust-lang#136148 (Optionally add type names to `TypeId`s.)
 - rust-lang#136609 (libcore/net: `IpAddr::as_octets()`)
 - rust-lang#137336 (Stabilise `os_str_display`)
 - rust-lang#137350 (Move methods from Map to TyCtxt, part 3.)
 - rust-lang#137353 (Implement `read_buf` for WASI stdin)
 - rust-lang#137361 (Refactor `OperandRef::extract_field` to prep for MCP838)
 - rust-lang#137367 (Do not exempt nonexistent platforms from platform policy)
 - rust-lang#137374 (Stacker now handles miri using a noop impl itself)
 - rust-lang#137392 (remove few unused fields)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
@bors
Auto merge of rust-lang#137397 - matthiaskrgr:rollup-ls2pilo, r=matth…
6a5acde 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#132876 (rustdoc book: acknowledge --document-hidden-items)
 - rust-lang#136148 (Optionally add type names to `TypeId`s.)
 - rust-lang#136609 (libcore/net: `IpAddr::as_octets()`)
 - rust-lang#137336 (Stabilise `os_str_display`)
 - rust-lang#137350 (Move methods from Map to TyCtxt, part 3.)
 - rust-lang#137353 (Implement `read_buf` for WASI stdin)
 - rust-lang#137361 (Refactor `OperandRef::extract_field` to prep for MCP838)
 - rust-lang#137367 (Do not exempt nonexistent platforms from platform policy)
 - rust-lang#137374 (Stacker now handles miri using a noop impl itself)
 - rust-lang#137392 (remove few unused fields)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 11, 2025
@matthiaskrgr
Rollup merge of rust-lang#137504 - nnethercote:remove-Map-4, r=Zalathar
cb81162 
Move methods from Map to TyCtxt, part 4.

A follow-up to rust-lang#137350.

r? ``@Zalathar``
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2025
@bors
Auto merge of rust-lang#137504 - nnethercote:remove-Map-4, r=<try>
8becda1 
Move methods from Map to TyCtxt, part 4.

A follow-up to rust-lang#137350.

r? `@Zalathar`
nnethercote added a commit to nnethercote/rust that referenced this pull request Mar 11, 2025
@nnethercote
Move methods from Map to TyCtxt, part 4.
256c27e 
Continuing the work from rust-lang#137350.

Removes the unused methods: `expect_variant`, `expect_field`,
`expect_foreign_item`.

Every method gains a `hir_` prefix.
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 12, 2025
@jieyouxu
Rollup merge of rust-lang#137504 - nnethercote:remove-Map-4, r=Zalathar
6872f4f 
Move methods from Map to TyCtxt, part 4.

A follow-up to rust-lang#137350.

r? `@Zalathar`
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 12, 2025
@jieyouxu
Rollup merge of rust-lang#137504 - nnethercote:remove-Map-4, r=Zalathar
33ddf0c 
Move methods from Map to TyCtxt, part 4.

A follow-up to rust-lang#137350.

r? ``@Zalathar``
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 12, 2025
@Manishearth
Rollup merge of rust-lang#137504 - nnethercote:remove-Map-4, r=Zalathar
f88f27a 
Move methods from Map to TyCtxt, part 4.

A follow-up to rust-lang#137350.

r? ```@Zalathar```
jieyouxu pushed a commit to jieyouxu/rustc-dev-guide that referenced this pull request Mar 13, 2025
@Manishearth
Rollup merge of #137504 - nnethercote:remove-Map-4, r=Zalathar
0d36dfa 
Move methods from Map to TyCtxt, part 4.

A follow-up to rust-lang/rust#137350.

r? ```@Zalathar```
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 14, 2025
@Manishearth
Rollup merge of #137504 - nnethercote:remove-Map-4, r=Zalathar
30a835b 
Move methods from Map to TyCtxt, part 4.

A follow-up to rust-lang/rust#137350.

r? ```@Zalathar```
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 20, 2025
@nnethercote
Move methods from Map to TyCtxt, part 4.
650b7d9 
Continuing the work from rust-lang#137350.

Removes the unused methods: `expect_variant`, `expect_field`,
`expect_foreign_item`.

Every method gains a `hir_` prefix.
@nnethercote nnethercote mentioned this pull request Apr 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Zalathar Zalathar

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.87.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nnethercote @rustbot @rust-log-analyzer @Zalathar @bors