Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lexer: Disallow some leading underscores in float exponents #137394

Closed
wants to merge 1 commit into from
Closed

lexer: Disallow some leading underscores in float exponents #137394

wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

A second, scaled down, attempt at #114567.
cc #111628 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 21, 2025
@petrochenkov
Copy link
Contributor Author

@bors try

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2025
@bors
Copy link
Collaborator

bors commented Feb 21, 2025

⌛ Trying commit f77e219 with merge f17e3a3...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2025
@bors
Auto merge of rust-lang#137394 - petrochenkov:nounderexp, r=<try>
f17e3a3 
lexer: Disallow some leading underscores in float exponents

A second, scaled down, attempt at rust-lang#114567.
cc rust-lang#111628 (comment)
@bors
Copy link
Collaborator

bors commented Feb 21, 2025

☀️ Try build successful - checks-actions
Build commit: f17e3a3 (f17e3a389e192f83fe27a581774a9d1dbb8e565b)

@petrochenkov
Copy link
Contributor Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-137394 created and queued.
🤖 Automatically detected try build f17e3a3
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-137394 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-137394 is completed!
📊 168 regressed and 5 fixed (586694 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 22, 2025
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2025
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Feb 24, 2025 •
edited
Loading

There's one root regression in the crate simd-json.
The wide range of versions is affected (from 0.7.0 to 0.14.3) and that crate is occasionally used by other crates in the ecosystem.
UPD: PR to simd-json removing the underscore - simd-lite/simd-json#415.

I'll return to this proposal after trying to implement #111628 (comment) with the current lexical grammar.

petrochenkov added a commit to petrochenkov/simd-json that referenced this pull request Feb 24, 2025
@petrochenkov
Remove an underscore in floating point exponent
fd06b0a 
This is a questionable feature in Rust lexer and `simd-json` is the only known crate on crates.io that is using it.
It's not being removed *yet*, but it would still be better to avoid using it.

See rust-lang/rust#137394 and linked issues for more details.
@petrochenkov petrochenkov mentioned this pull request Feb 24, 2025
Merged
@petrochenkov petrochenkov deleted the nounderexp branch February 24, 2025 12:37
Licenser pushed a commit to simd-lite/simd-json that referenced this pull request Feb 25, 2025
@petrochenkov @Licenser
Remove an underscore in floating point exponent
eb7409b 
This is a questionable feature in Rust lexer and `simd-json` is the only known crate on crates.io that is using it.
It's not being removed *yet*, but it would still be better to avoid using it.

See rust-lang/rust#137394 and linked issues for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petrochenkov @rustbot @bors @craterbot @oli-obk