add back jemalloc to the tree #13742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestinger
changed the title
|
I started working on porting to this new allocator interface but extracted it from this commit for now. I ran into some code bloat issues in |
|
Is this following the design proposed in rust-lang/rfcs#39 ? |
|
Glad to see progress on this again. I like that it defines its own abstraction for the exchange heap. From a cursory look I think this enables jemalloc everywhere. Is that correct? |
|
I don't really understand why we would add a submodule, build it, and then never use it. I would like to see at least one user of jemalloc before merging. |
|
@alexcrichton: If it's okay to have a bunch compiler changes along with this, then I'll do that. |
This adds a `std::rt::heap` module with a nice allocator API. It's a step towards fixing #13094 and is a starting point for working on a generic allocator trait. The revision used for the jemalloc submodule is the stable 3.6.0 release.
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Dec 17, 2022
…ts, r=flodiebold fix: only shift `BoundVar`s that come from outside lowering context Fixes rust-lang#13734 There are some free functions `TyLoweringContext` methods call, which do not know anything about current binders in scope. We need to shift in the `BoundVar`s in substitutions that we get from them (rust-lang#4952), but not those we get from `TyLoweringContext` methods.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 15, 2024
…lang#13742) changelog: [`doc_lazy_continuation`]: correctly count indent with backslashes Fixes rust-lang#13705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
std::rt::heapmodule with a nice allocator API. It's astep towards fixing #13094 and is a starting point for working on a
generic allocator trait.
The revision used for the jemalloc submodule is the stable 3.6.0 release.