[perf experiment] Link rlibs with --whole-archive
#137481
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
dianqk
changed the title
--whole-archive--whole-archive
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2025
[perf experiment] Link rlibs with `--whole-archive` For rust-lang#137426 (comment). r? ghost
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2025
[perf experiment] Link rlibs with `--whole-archive` For rust-lang#137426 (comment). r? ghost
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
dianqk
force-pushed
the
whole-archive
branch
from
fb38743 to
73d739f
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 24, 2025
[perf experiment] Link rlibs with `--whole-archive` For rust-lang#137426 (comment). r? ghost
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (80ade6f): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary -4.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 7.6%, secondary 11.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 3.3%, secondary 9.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 770.257s -> 770.402s (0.02%) |
rustbot
added
perf-regression
|
It's not bad for me, the obvious increases are all small examples. |
|
Do you think it'd be possible to test the performance differential with Apple's |
Yes. But there's no infrastructure at all yet. |
Originally posted by @ChrisDenton in #137426 (comment) I know nothing about Windows, so I'm closing the PR. Free to pick it. Originally posted by @bjorn3 in #137426 (comment) I gave this some more thought, and I don't think it's a major problem. Why do we need to understand more about the linker's behavior when using C, whereas we don't have to with Rust? This struck me as a bit odd. I probably prefer to keep the default behavior as it is in C (or the default behavior of linker). If |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #137426 (comment).
r? ghost