tests: use minicore more #137599
Merged
tests: use minicore more #137599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minicore makes it much easier to add new language items to all of the existing `no_core` tests.
rustbot
added
PG-exploit-mitigations
|
Some changes occurred in tests/codegen/stack-probes-inline.rs cc @rust-lang/project-exploit-mitigations, @rcvalle Some changes occurred in tests/codegen/sanitizer cc @rust-lang/project-exploit-mitigations, @rcvalle Some changes occurred in tests/ui/sanitizer cc @rust-lang/project-exploit-mitigations, @rcvalle |
jieyouxu
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Thanks for working on this! Most of the tests look good to me, however I noticed a few tests that has minor problems, should not / cannot use minicore, and a few unexpected changes. With the changes in this PR, I think I can see a better guideline for when to use minicore. In general, I think minicore...
- Should be used when one wants a
no_coreui/assembly/codegen test for ABI/codegen/layout purposes, and maybe some other use cases - Should not be used if the test is exercising diagnostics or
lang_item-handling itself, or if usingminicorecan complicate debugging (such as when a resolve test fails)
We should add that to rustc-dev-guide. Maybe you have suggestions for refinements?
tests/ui/associated-types/associated-types-ICE-when-projecting-out-of-err.rs
Outdated
Show resolved
Hide resolved
tests/ui/associated-types/associated-types-ICE-when-projecting-out-of-err.stderr
Show resolved
Hide resolved
rustbot
added
S-waiting-on-author
davidtwco
force-pushed
the
use-minicore-more
branch
from
527ce54 to
92eb445
Compare
This makes sense to me, but I think diagnostics changing by itself doesn't mean that minicore shouldn't be used, it depends on the specific change - some tests will have a diagnostic change for irrelevant reasons (as in |
davidtwco
added
S-waiting-on-review
|
Yeah, the classic "It Depends" situation 😆 |
|
@bors r+ rollup=maybe |
bors
added
S-waiting-on-bors
davidtwco
added a commit
to davidtwco/rust
that referenced
this pull request
Feb 26, 2025
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Feb 28, 2025
…youxu tests: use minicore more minicore makes it much easier to add new language items to all of the existing `no_core` tests. Most of the remaining tests that *could* use minicore either fail because.. 1. LLVM IR output changes and doesn't pass the test as written. I didn't look into these further. 2. The test has revisions w/ different compilation flags, expecting some to fail, and when using minicore, minicore is compiled with those flags and fails in the expected way because of the flags rather than the test, and that's considered a failure. But these tests can be changed and make adding new language items a lot easier. r? `@jieyouxu`
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Feb 28, 2025
…youxu tests: use minicore more minicore makes it much easier to add new language items to all of the existing `no_core` tests. Most of the remaining tests that *could* use minicore either fail because.. 1. LLVM IR output changes and doesn't pass the test as written. I didn't look into these further. 2. The test has revisions w/ different compilation flags, expecting some to fail, and when using minicore, minicore is compiled with those flags and fails in the expected way because of the flags rather than the test, and that's considered a failure. But these tests can be changed and make adding new language items a lot easier. r? ``@jieyouxu``
This was referenced Feb 28, 2025
davidtwco
added a commit
to davidtwco/rust
that referenced
this pull request
Feb 28, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2025
Rollup of 10 pull requests Successful merges: - rust-lang#134943 (Add FileCheck annotations to mir-opt/issues) - rust-lang#137017 (Don't error when adding a staticlib with bitcode files compiled by newer LLVM) - rust-lang#137197 (Update some comparison codegen tests now that they pass in LLVM20) - rust-lang#137540 (Fix (more) test directives that were accidentally ignored) - rust-lang#137551 (import `simd_` intrinsics) - rust-lang#137599 (tests: use minicore more) - rust-lang#137673 (Fix Windows `Command` search path bug) - rust-lang#137676 (linker: Fix escaping style for response files on Windows) - rust-lang#137693 (Re-enable `--generate-link-to-defintion` for tools internal rustdoc) - rust-lang#137770 (Fix sized constraint for unsafe binder) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2025
Rollup merge of rust-lang#137599 - davidtwco:use-minicore-more, r=jieyouxu tests: use minicore more minicore makes it much easier to add new language items to all of the existing `no_core` tests. Most of the remaining tests that *could* use minicore either fail because.. 1. LLVM IR output changes and doesn't pass the test as written. I didn't look into these further. 2. The test has revisions w/ different compilation flags, expecting some to fail, and when using minicore, minicore is compiled with those flags and fails in the expected way because of the flags rather than the test, and that's considered a failure. But these tests can be changed and make adding new language items a lot easier. r? ```@jieyouxu```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minicore makes it much easier to add new language items to all of the existing
no_coretests.Most of the remaining tests that could use minicore either fail because..
But these tests can be changed and make adding new language items a lot easier.
r? @jieyouxu