Don't suggest constraining unstable associated types #137635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
Feb 26, 2025
…, r=SparrowLii Don't suggest constraining unstable associated types Fixes rust-lang#137624 This could be made a bit more specific, considering the local crate's stability or nightly status or something, but I think in general we should not be suggesting associated type bounds on unstable associated items.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup of 10 pull requests Successful merges: - rust-lang#134585 (remove `MaybeUninit::uninit_array`) - rust-lang#136187 (Use less CString in the examples of CStr.) - rust-lang#136457 (Expose algebraic floating point intrinsics) - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`) - rust-lang#137620 (Fix `attr` cast for espidf) - rust-lang#137631 (Avoid collecting associated types for undefined trait) - rust-lang#137635 (Don't suggest constraining unstable associated types) - rust-lang#137642 (Rustc dev guide subtree update) - rust-lang#137660 (Update gcc submodule) - rust-lang#137670 (revert accidental change in get_closest_merge_commit) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup of 10 pull requests Successful merges: - rust-lang#134585 (remove `MaybeUninit::uninit_array`) - rust-lang#136187 (Use less CString in the examples of CStr.) - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`) - rust-lang#137620 (Fix `attr` cast for espidf) - rust-lang#137631 (Avoid collecting associated types for undefined trait) - rust-lang#137635 (Don't suggest constraining unstable associated types) - rust-lang#137642 (Rustc dev guide subtree update) - rust-lang#137660 (Update gcc submodule) - rust-lang#137670 (revert accidental change in get_closest_merge_commit) - rust-lang#137671 (Make -Z unpretty=mir suggest -Z dump-mir as well for discoverability) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup merge of rust-lang#137635 - compiler-errors:constrain-unstable, r=SparrowLii Don't suggest constraining unstable associated types Fixes rust-lang#137624 This could be made a bit more specific, considering the local crate's stability or nightly status or something, but I think in general we should not be suggesting associated type bounds on unstable associated items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137624
This could be made a bit more specific, considering the local crate's stability or nightly status or something, but I think in general we should not be suggesting associated type bounds on unstable associated items.