Skip to content

Enable f16 for LoongArch #137674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

Enable f16 for LoongArch #137674

merged 1 commit into from
Mar 7, 2025

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Feb 26, 2025 •
edited by tgross35
Loading

Blocked on rust-lang/compiler-builtins#770

r? @tgross35

Tracking issue for f16: #116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2025

Failed to set assignee to [@tgross35]: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 26, 2025
tgross35
tgross35 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after the builtins change makes it in

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2025
@tgross35
Copy link
Contributor

tgross35 commented Mar 7, 2025

#138038 merged with the builtins update including this

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
@bors
Auto merge of rust-lang#137674 - heiher:enable-f16-loong, r=<try>
66aec18 
Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? `@tgross35`

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
@bors
Copy link
Collaborator

bors commented Mar 7, 2025

⌛ Trying commit 30703af with merge 66aec18...

@bors
Copy link
Collaborator

bors commented Mar 7, 2025

☀️ Try build successful - checks-actions
Build commit: 66aec18 (66aec1841d22643fe5ac597f4f3a41e88d02997c)

@tgross35
Copy link
Contributor

tgross35 commented Mar 7, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 7, 2025

📌 Commit 30703af has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 7, 2025
@jhpratt jhpratt mentioned this pull request Mar 7, 2025
Closed
This was referenced Mar 7, 2025
Closed
Merged
@bors bors merged commit 6e7d135 into rust-lang:master Mar 7, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 7, 2025
@heiher heiher deleted the enable-f16-loong branch March 18, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
4 participants
@heiher @rustbot @tgross35 @bors