-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Demote i686-pc-windows-gnu to Tier 2 #137869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 1 commit into
rust-lang:master
from
Noratrieb:Now_I_am_become_death,_the_destroyer_of_i686-pc-windows-gnu
Apr 4, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -501,7 +501,7 @@ auto: | |
env: | ||
SCRIPT: > | ||
python x.py test --stage 2 src/tools/miri --target aarch64-apple-darwin --test-args pass && | ||
python x.py test --stage 2 src/tools/miri --target i686-pc-windows-gnu --test-args pass && | ||
python x.py test --stage 2 src/tools/miri --target x86_64-pc-windows-gnu --test-args pass && | ||
python x.py miri --stage 2 library/core --test-args notest && | ||
python x.py miri --stage 2 library/alloc --test-args notest && | ||
python x.py miri --stage 2 library/std --test-args notest | ||
|
@@ -533,31 +533,6 @@ auto: | |
# came from the mingw-w64 SourceForge download site. Unfortunately | ||
# SourceForge is notoriously flaky, so we mirror it on our own infrastructure. | ||
|
||
# i686-mingw is split into three jobs to run tests in parallel. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❤️ |
||
- name: i686-mingw-1 | ||
env: | ||
RUST_CONFIGURE_ARGS: --build=i686-pc-windows-gnu | ||
SCRIPT: make ci-mingw-x-1 | ||
# There is no dist-i686-mingw-alt, so there is no prebuilt LLVM with assertions | ||
NO_DOWNLOAD_CI_LLVM: 1 | ||
<<: *job-windows-25 | ||
|
||
- name: i686-mingw-2 | ||
env: | ||
RUST_CONFIGURE_ARGS: --build=i686-pc-windows-gnu | ||
SCRIPT: make ci-mingw-x-2 | ||
# There is no dist-i686-mingw-alt, so there is no prebuilt LLVM with assertions | ||
NO_DOWNLOAD_CI_LLVM: 1 | ||
<<: *job-windows-25 | ||
|
||
- name: i686-mingw-3 | ||
env: | ||
RUST_CONFIGURE_ARGS: --build=i686-pc-windows-gnu | ||
SCRIPT: make ci-mingw-bootstrap | ||
# There is no dist-i686-mingw-alt, so there is no prebuilt LLVM with assertions | ||
NO_DOWNLOAD_CI_LLVM: 1 | ||
<<: *job-windows-25 | ||
|
||
# x86_64-mingw is split into two jobs to run tests in parallel. | ||
- name: x86_64-mingw-1 | ||
env: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# \*-windows-gnu | ||
|
||
**⚠️ This documentation page is a stub, you can help improving it by sending a PR. ⚠️** | ||
|
||
**Tier: 1/2 (with host tools)** | ||
|
||
Target triples available: | ||
- `i686-pc-windows-gnu`: Tier 2 | ||
- `x86_64-pc-windows-gnu`: Tier 1 | ||
|
||
## Target maintainers | ||
|
||
**⚠️ These targets do not have any maintainers and are not properly maintained. ⚠️** | ||
|
||
If you are using this target, consider signing up to become a target maintainer. | ||
See the target tier policy for details. | ||
Without maintainers, these targets may be demoted in the future. | ||
|
||
## Requirements | ||
|
||
These targets support std and host tools. | ||
|
||
Unlike their MSVC counterparts, windows-gnu targets support cross-compilation and are free of all MSVC licensing implications. | ||
|
||
They follow Windows calling convention for `extern "C"`. | ||
|
||
Like with any other Windows target, created binaries are in PE format. | ||
|
||
## Building Rust programs | ||
|
||
Rust does ship a pre-compiled std library for those targets. | ||
That means one can easily compile and cross-compile for those targets from other hosts if C proper toolchain is installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.