Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilise os_string_pathbuf_leak #137992

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

its-the-shrimp
Copy link
Contributor

This PR stabilises #[feature(os_string_pathbuf_leak)], which defines 2 new methods in the std:

impl OsString {
    pub fn leak<'a>(self) -> &'a mut OsStr;
}

impl PathBuf {
    pub fn leak<'a>(self) -> &'a mut Path;
}

ACP: rust-lang/libs-team#389
Tracking issue: #125965
Implementation: #125966

@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 4, 2025
@rust-log-analyzer

This comment has been minimized.

@its-the-shrimp its-the-shrimp force-pushed the stabilise_os_string_pathbuf_leak branch from 171e39d to e24d91d Compare March 4, 2025 11:45
@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2025
@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@its-the-shrimp its-the-shrimp force-pushed the stabilise_os_string_pathbuf_leak branch from 332f5a5 to 1a6315a Compare March 4, 2025 21:30
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2025
@rust-log-analyzer

This comment has been minimized.

@its-the-shrimp its-the-shrimp force-pushed the stabilise_os_string_pathbuf_leak branch from 1a6315a to 732b63c Compare March 4, 2025 21:43
@cuviper
Copy link
Member

cuviper commented Mar 4, 2025

This still needs FCP...

@rustbot label -T-libs +T-libs-api
r? libs-api

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 4, 2025
@rustbot rustbot assigned dtolnay and unassigned cuviper Mar 4, 2025
@dtolnay
Copy link
Member

dtolnay commented Mar 5, 2025

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Mar 5, 2025

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants