handle forced compiler and revert #137476 #138039

onur-ozkan · 2025-03-05T06:54:04Z

I would appreciate it if we could measure CI pipelines with the current changes to see if this reduces recent CI overhead. cc @rust-lang/infra

try-job: dist-powerpc64le-linux

rustbot · 2025-03-05T06:54:09Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-03-05T06:55:35Z

@onur-ozkan you could try-job the slowest job for a rough measurement (the dist ppcle64 or whatever it's called) that we know regressed in build time

onur-ozkan · 2025-03-05T06:57:04Z

We don't build tools on try-jobs, but I can add a small patch to force that for testing.

Kobzol · 2025-03-05T06:57:32Z

Yeah, it was the powerpc64 le one, I think (not on PC right now).

jieyouxu · 2025-03-05T06:58:28Z

Ah right, I forgot about the try-job tool build distinction again...

rustbot · 2025-03-05T07:13:12Z

Some changes occurred in src/tools/opt-dist

cc @Kobzol

onur-ozkan · 2025-03-05T07:14:35Z

@bors try

…-tools, r=<try> handle forced compiler and revert rust-lang#137476 Fixes rust-lang#138004 I would appreciate it if we could measure CI pipelines with the current changes to see if this reduces recent CI overhead. cc `@rust-lang/infra` try-job: powerpc64le-unknown-linux-gnu

bors · 2025-03-05T07:15:46Z

⌛ Trying commit cd0f743 with merge b46218a...

onur-ozkan · 2025-03-05T07:18:38Z

Messed up with the job name on the previous call. @bors try

bors · 2025-03-05T07:20:27Z

⌛ Trying commit cd0f743 with merge dcee436...

…-tools, r=<try> handle forced compiler and revert rust-lang#137476 Fixes rust-lang#138004 I would appreciate it if we could measure CI pipelines with the current changes to see if this reduces recent CI overhead. cc `@rust-lang/infra` try-job: dist-powerpc64le-linux

Kobzol · 2025-03-05T07:36:02Z

Try builds are different only for jobs that use the PGO/BOLT optimization pipeline. For the PowerPC job, try job is exactly the same as an auto job.

onur-ozkan · 2025-03-05T07:45:07Z

x86_64-gnu-llvm-18 failed two times in a row due to network specific problem on Gcc step.

Kobzol · 2025-03-05T07:45:55Z

Yeah, we might want to host the GCC dependencies on our mirrors, I'll open an infra topic.

Kobzol · 2025-03-05T08:26:10Z

For reference, the job duration was ~2h45m before #137476, and ~3h15m after it.

Kobzol · 2025-03-05T10:22:38Z

I have a script that compares the executed bootstrap stages (later I want to add this functionality to #138013), I'll run it on the output once it finishes. So far it seems to be on the slower side though :/

bors · 2025-03-05T10:25:20Z

☀️ Try build successful - checks-actions
Build commit: dcee436 (dcee43656ab7006cc54b48e0dfa13a9ce144a576)

onur-ozkan · 2025-03-05T10:26:01Z

Maybe it's not just about #137476? We shouldn't get the build overhead of #137476 in this PR.

Signed-off-by: onur-ozkan <work@onurozkan.dev>

bors · 2025-03-06T09:51:59Z

📌 Commit 64dd484 has been approved by jieyouxu

It is now in the queue for this repository.

bors · 2025-03-06T09:52:00Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

bors · 2025-03-06T14:16:03Z

⌛ Testing commit 64dd484 with merge 0e29361...

…-tools, r=jieyouxu handle forced compiler and revert rust-lang#137476 Fixes rust-lang#138004 I would appreciate it if we could measure CI pipelines with the current changes to see if this reduces recent CI overhead. cc `@rust-lang/infra` try-job: dist-powerpc64le-linux

ehuss · 2025-03-06T15:02:21Z

(Not a blocker) With this PR, it still seems like it is building the compiler an extra unnecessary time:

Building compiler artifacts (stage1:x86_64-unknown-linux-gnu -> stage2:powerpc64le-unknown-linux-gnu)
Building compiler artifacts (stage0:x86_64-unknown-linux-gnu -> stage1:powerpc64le-unknown-linux-gnu)

I would not expect that second build to the host architecture. I would expect that "stage1" compiler to not be used at all (it is not used for compiling anything, and it is not included in the dist artifacts).

Do we know why that is happening?

Kobzol · 2025-03-06T15:07:48Z

(Just noting that this might explain the "missing" 15 minutes).

jieyouxu · 2025-03-06T15:47:21Z

(Not a blocker) With this PR, it still seems like it is building the compiler an extra unnecessary time:
Building compiler artifacts (stage1:x86_64-unknown-linux-gnu -> stage2:powerpc64le-unknown-linux-gnu)
Building compiler artifacts (stage0:x86_64-unknown-linux-gnu -> stage1:powerpc64le-unknown-linux-gnu)
I would not expect that second build to the host architecture. I would expect that "stage1" compiler to not be used at all (it is not used for compiling anything, and it is not included in the dist artifacts).

Do we know why that is happening?

@ehuss can you share what config.toml you used, and the invocation you used (I ask because ./x dist with no args can differ vs ./x dist with path filters)? I can look into it.

rust-log-analyzer · 2025-03-06T16:02:25Z

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [mir-opt] tests\mir-opt\slice_drop_shim.rs stdout ----

error: compilation failed!
status: exit code: 0xc00000fd
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\mir-opt\\slice_drop_shim.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--target=x86_64-pc-windows-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "-Copt-level=1" "-Zdump-mir=AddMovesForPackedDrops | AddMovesForPackedDrops" "-Zvalidate-mir" "-Zlint-mir" "-Zdump-mir-exclude-pass-number" "-Zmir-include-spans=false" "--crate-type=rlib" "-Zmir-opt-level=4" "-Zmir-enable-passes=+ReorderBasicBlocks,+ReorderLocals" "-Zdump-mir-dir=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\mir-opt\\slice_drop_shim" "--emit" "mir" "-C" "prefer-dynamic" "--out-dir" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\mir-opt\\slice_drop_shim" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\native\\rust-test-helpers" "-Zmir-opt-level=0" "-Clink-dead-code"
--- stderr -------------------------------
warning: function `main` is never used
##[warning] --> D:\a\rust\rust\tests\mir-opt\slice_drop_shim.rs:9:4
  |
---
test result: FAILED. 324 passed; 1 failed; 3 ignored; 0 measured; 0 filtered out; finished in 12.84s

Some tests failed in compiletest suite=mir-opt mode=mir-opt host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:36:44
make: *** [Makefile:126: ci-mingw-x] Error 1
  network time: Thu, 06 Mar 2025 16:02:06 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

bors · 2025-03-06T16:02:57Z

💔 Test failed - checks-actions

jieyouxu · 2025-03-06T16:13:21Z

STATUS_STACK_OVERFLOW 🤔 Let me run this locally...

jieyouxu · 2025-03-06T16:50:34Z

I can't seem to repro this locally on mingw. Let's see if it's spurious; I'll open an issue to track this.

EDIT: #138110

@bors retry

bors · 2025-03-06T17:20:28Z

⌛ Testing commit 64dd484 with merge e6af292...

onur-ozkan · 2025-03-06T18:06:30Z

(Not a blocker) With this PR, it still seems like it is building the compiler an extra unnecessary time:
Building compiler artifacts (stage1:x86_64-unknown-linux-gnu -> stage2:powerpc64le-unknown-linux-gnu)

Building compiler artifacts (stage0:x86_64-unknown-linux-gnu -> stage1:powerpc64le-unknown-linux-gnu)
I would not expect that second build to the host architecture. I would expect that "stage1" compiler to not be used at all (it is not used for compiling anything, and it is not included in the dist artifacts).

Do we know why that is happening?

Yeah, we can avoid that too, but are you sure that this wasn't happening before #137476?

ehuss · 2025-03-06T19:35:14Z

I posted my notes into #138123. I only compared after this PR, and before #137215, and only with a few configs.

bors · 2025-03-06T20:24:40Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing e6af292 to master...

rust-timer · 2025-03-06T21:41:10Z

Finished benchmarking commit (e6af292): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-4.1%, -3.7%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.363s -> 774.453s (0.14%)
Artifact size: 362.14 MiB -> 362.07 MiB (-0.02%)

rustbot assigned Mark-Simulacrum Mar 5, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 5, 2025

onur-ozkan mentioned this pull request Mar 5, 2025

avoid compiler_for for dist tools and force the current compiler #137476

Merged

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 5, 2025

onur-ozkan force-pushed the handle-forced-compiler-on-tools branch from ae78953 to cd0f743 Compare March 5, 2025 07:13

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

onur-ozkan added 2 commits March 5, 2025 13:28

add new field forced_compiler to Compiler

b885407

Signed-off-by: onur-ozkan <work@onurozkan.dev>

handle forced compiler in get_tool_rustc_compiler

9e4b3d6

Signed-off-by: onur-ozkan <work@onurozkan.dev>

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025

jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Mar 6, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 6, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025

jieyouxu mentioned this pull request Mar 6, 2025

tests/mir-opt/slice_drop_shim.rs spuriously fails on x86_64 mingw with 0xc00000fd #138110

Closed

ehuss mentioned this pull request Mar 6, 2025

Some configurations build the compiler too many times #138123

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 6, 2025

bors merged commit e6af292 into rust-lang:master Mar 6, 2025
7 checks passed

rustbot added this to the 1.87.0 milestone Mar 6, 2025

onur-ozkan deleted the handle-forced-compiler-on-tools branch March 7, 2025 06:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

handle forced compiler and revert #137476 #138039

handle forced compiler and revert #137476 #138039

onur-ozkan commented Mar 5, 2025 •

edited

Loading

rustbot commented Mar 5, 2025

jieyouxu commented Mar 5, 2025

onur-ozkan commented Mar 5, 2025

Kobzol commented Mar 5, 2025

jieyouxu commented Mar 5, 2025

rustbot commented Mar 5, 2025

onur-ozkan commented Mar 5, 2025

bors commented Mar 5, 2025

This comment has been minimized.

onur-ozkan commented Mar 5, 2025

bors commented Mar 5, 2025

This comment was marked as outdated.

Kobzol commented Mar 5, 2025 •

edited

Loading

onur-ozkan commented Mar 5, 2025 •

edited

Loading

Kobzol commented Mar 5, 2025

Kobzol commented Mar 5, 2025

Kobzol commented Mar 5, 2025

bors commented Mar 5, 2025

onur-ozkan commented Mar 5, 2025

bors commented Mar 6, 2025

bors commented Mar 6, 2025

bors commented Mar 6, 2025

ehuss commented Mar 6, 2025

Kobzol commented Mar 6, 2025

jieyouxu commented Mar 6, 2025 •

edited

Loading

rust-log-analyzer commented Mar 6, 2025

bors commented Mar 6, 2025

jieyouxu commented Mar 6, 2025 •

edited

Loading

jieyouxu commented Mar 6, 2025 •

edited

Loading

bors commented Mar 6, 2025

onur-ozkan commented Mar 6, 2025

ehuss commented Mar 6, 2025

bors commented Mar 6, 2025

rust-timer commented Mar 6, 2025

handle forced compiler and revert #137476 #138039

handle forced compiler and revert #137476 #138039

Conversation

onur-ozkan commented Mar 5, 2025 • edited Loading

rustbot commented Mar 5, 2025

jieyouxu commented Mar 5, 2025

onur-ozkan commented Mar 5, 2025

Kobzol commented Mar 5, 2025

jieyouxu commented Mar 5, 2025

rustbot commented Mar 5, 2025

onur-ozkan commented Mar 5, 2025

bors commented Mar 5, 2025

This comment has been minimized.

onur-ozkan commented Mar 5, 2025

bors commented Mar 5, 2025

This comment was marked as outdated.

Kobzol commented Mar 5, 2025 • edited Loading

onur-ozkan commented Mar 5, 2025 • edited Loading

Kobzol commented Mar 5, 2025

Kobzol commented Mar 5, 2025

Kobzol commented Mar 5, 2025

bors commented Mar 5, 2025

onur-ozkan commented Mar 5, 2025

bors commented Mar 6, 2025

bors commented Mar 6, 2025

bors commented Mar 6, 2025

ehuss commented Mar 6, 2025

Kobzol commented Mar 6, 2025

jieyouxu commented Mar 6, 2025 • edited Loading

rust-log-analyzer commented Mar 6, 2025

bors commented Mar 6, 2025

jieyouxu commented Mar 6, 2025 • edited Loading

jieyouxu commented Mar 6, 2025 • edited Loading

bors commented Mar 6, 2025

onur-ozkan commented Mar 6, 2025

ehuss commented Mar 6, 2025

bors commented Mar 6, 2025

rust-timer commented Mar 6, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

onur-ozkan commented Mar 5, 2025 •

edited

Loading

Kobzol commented Mar 5, 2025 •

edited

Loading

onur-ozkan commented Mar 5, 2025 •

edited

Loading

jieyouxu commented Mar 6, 2025 •

edited

Loading

jieyouxu commented Mar 6, 2025 •

edited

Loading

jieyouxu commented Mar 6, 2025 •

edited

Loading