Pass InferCtxt to InlineAsmCtxt to properly taint on error
#138138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
oli-obk
approved these changes
Mar 7, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Split up some of the tests bc tainting causes some errors to become suppressed
compiler-errors
force-pushed
the
inline-asm-tainting
branch
from
77ea82b to
bc4f0bb
Compare
|
Rebased out that other commit @bors r=oli-obk |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#137931 (Add remark for missing `llvm-tools` component re. `rustc_private` linker failures related to not finding LLVM libraries) - rust-lang#138138 (Pass `InferCtxt` to `InlineAsmCtxt` to properly taint on error) - rust-lang#138223 (Fix post-merge workflow) - rust-lang#138268 (Handle empty test suites in GitHub job summary report) - rust-lang#138278 (Delegation: fix ICE with invalid `MethodCall` generation) - rust-lang#138281 (Fix O(tests) stack usage in edition 2024 mergeable doctests) - rust-lang#138305 (Subtree update of `rust-analyzer`) - rust-lang#138306 (Revert "Use workspace lints for crates in `compiler/` rust-lang#138084") r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2025
Rollup merge of rust-lang#138138 - compiler-errors:inline-asm-tainting, r=oli-obk Pass `InferCtxt` to `InlineAsmCtxt` to properly taint on error Pass an `InferCtxt` into the `InlineAsmCtxt` so that we can use the right dcx to taint the infcx properly, so that we don't try to build invalid MIR for inline asm blocks. Fixes rust-lang#138130 Shares the first commit with rust-lang#137502. r? oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass an
InferCtxtinto theInlineAsmCtxtso that we can use the right dcx to taint the infcx properly, so that we don't try to build invalid MIR for inline asm blocks.Fixes #138130
Shares the first commit with #137502.
r? oli-obk