Rewrite inline attribute parser to use new infrastructure and improve diagnostics for all parsed attributes
#138165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdonszelmann
commented
Mar 8, 2025
| @@ -584,7 +546,6 @@ fn codegen_fn_attrs(tcx: TyCtxt<'_>, did: LocalDefId) -> CodegenFnAttrs { | |||
| return OptimizeAttr::Default; | |||
| }; | |||
|
|
|||
| inline_span = Some(attr.span()); | |||
There was a problem hiding this comment.
This fixes #137950
To do this we stuff them in the diagnostic context to be emitted after hir is constructed
jdonszelmann
force-pushed
the
inline
branch
2 times, most recently
from
e6dad01 to
2a707bf
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #138302) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk
WIP, some other PRs need to merge first but I wanted to open this one already to track progress
Closes #137950