Get rid of `EscapeDebugInner`. #138237

reitermarkus · 2025-03-08T20:14:13Z

I read the note on EscapeDebugInner and thought I'd give it a try.

rustbot · 2025-03-08T20:14:17Z

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

library/core/src/char/mod.rs

library/core/src/escape.rs

hkBst · 2025-03-11T08:34:08Z

-        // SAFETY: `self.data.escape_seq` contains an escape sequence, as is 
-        // guaranteed by the caller, and in that case `self.alive` is guaranteed 
+        // SAFETY: `self.data.escape_seq` contains an escape sequence, as is
+        // guaranteed by the caller, and in that case `self.alive` is guaranteed

I'm sure you know this, but if you highlight these lines, you can see that the trailing space is the problem.

Rollup of 7 pull requests Successful merges: - #138237 (Get rid of `EscapeDebugInner`.) - #140809 (Reduce special casing for the panic runtime) - #141990 (Implement send_signal for unix child processes) - #142082 (Refactor `rustc_attr_data_structures` documentation) - #142125 (Stabilize "file_lock" feature) - #142528 (clarify `rustc_do_not_const_check` comment) - #142530 (use `if let` guards where possible) r? `@ghost` `@rustbot` modify labels: rollup

…oss35 Get rid of `EscapeDebugInner`. I read the note on `EscapeDebugInner` and thought I'd give it a try.

bors · 2025-06-16T07:48:29Z

⌛ Testing commit ce457e1 with merge b0eab47...

rust-log-analyzer · 2025-06-16T08:43:47Z

The job dist-i586-gnu-i586-i686-musl failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2025-06-16T08:48:58Z

💔 Test failed - checks-actions

tgross35 · 2025-06-17T10:40:40Z

Seems unrelated?

@bors2 try jobs=dist-i586-gnu-i586-i686-musl

rust-bors · 2025-06-17T10:40:43Z

Unknown value for argument "jobs".

tgross35 · 2025-06-17T10:41:23Z

Should be...
@bors2 try jobs=dist-i586-gnu-i586-i686-musl

rust-bors · 2025-06-17T10:41:27Z

⌛ Trying commit ce457e1 with merge 68d5650…

To cancel the try build, run the command @bors2 try cancel.

Get rid of `EscapeDebugInner`.    I read the note on `EscapeDebugInner` and thought I'd give it a try. try-job: dist-i586-gnu-i586-i686-musl

rust-bors · 2025-06-17T12:21:27Z

☀️ Try build successful (CI)
Build commit: 68d5650 (68d56507c033370b3289981f6c124b8c4e6917d8, parent: 55d436467c351b56253deeba209ae2553d1c243f)

tgross35 · 2025-06-17T16:03:15Z

@bors r+

bors · 2025-06-17T16:03:17Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Sized Hierarchy: Part I #137944

bors · 2025-06-17T16:03:18Z

📌 Commit ce457e1 has been approved by tgross35

It is now in the queue for this repository.

…nner, r=tgross35 Get rid of `EscapeDebugInner`. I read the note on `EscapeDebugInner` and thought I'd give it a try.

Rollup of 10 pull requests Successful merges: - #135656 (Add `-Z hint-mostly-unused` to tell rustc that most of a crate will go unused) - #138237 (Get rid of `EscapeDebugInner`.) - #140772 ({aarch64,x86_64}-pc-windows-gnullvm: build host tools) - #140774 (Affirm `-Cforce-frame-pointers=off` does not override) - #141610 (Stabilize `feature(generic_arg_infer)`) - #141864 (Handle win32 separator for cygwin paths) - #142384 (Bringing `rustc_rayon_core` in tree as `rustc_thread_pool`) - #142502 (rustdoc_json: improve handling of generic args) - #142571 (Reason about borrowed classes in CopyProp.) - #142591 (Add spawn APIs for BootstrapCommand to support deferred command execution) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 6 pull requests Successful merges: - #135656 (Add `-Z hint-mostly-unused` to tell rustc that most of a crate will go unused) - #138237 (Get rid of `EscapeDebugInner`.) - #141614 (lint direct use of rustc_type_ir ) - #142123 (Implement initial support for timing sections (`--json=timings`)) - #142377 (Try unremapping compiler sources) - #142674 (remove duplicate crash test) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 6 pull requests Successful merges: - rust-lang/rust#135656 (Add `-Z hint-mostly-unused` to tell rustc that most of a crate will go unused) - rust-lang/rust#138237 (Get rid of `EscapeDebugInner`.) - rust-lang/rust#141614 (lint direct use of rustc_type_ir ) - rust-lang/rust#142123 (Implement initial support for timing sections (`--json=timings`)) - rust-lang/rust#142377 (Try unremapping compiler sources) - rust-lang/rust#142674 (remove duplicate crash test) r? `@ghost` `@rustbot` modify labels: rollup

…nner, r=tgross35 Get rid of `EscapeDebugInner`. I read the note on `EscapeDebugInner` and thought I'd give it a try.

Rollup of 6 pull requests Successful merges: - rust-lang#135656 (Add `-Z hint-mostly-unused` to tell rustc that most of a crate will go unused) - rust-lang#138237 (Get rid of `EscapeDebugInner`.) - rust-lang#141614 (lint direct use of rustc_type_ir ) - rust-lang#142123 (Implement initial support for timing sections (`--json=timings`)) - rust-lang#142377 (Try unremapping compiler sources) - rust-lang#142674 (remove duplicate crash test) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned thomcc Mar 8, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 8, 2025

reitermarkus force-pushed the remove-escape-debug-inner branch 3 times, most recently from 57c0a80 to 0854482 Compare March 8, 2025 20:52