Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repr128-dwarf test #138263

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Fix repr128-dwarf test #138263

merged 1 commit into from
Mar 9, 2025

Conversation

beetrees
Copy link
Contributor

@beetrees beetrees commented Mar 9, 2025

The test now correctly ignores enums from std.

Fixes #138254
Unblocks #138200

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2025

This PR modifies run-make tests.

cc @jieyouxu

@jieyouxu
Copy link
Member

jieyouxu commented Mar 9, 2025

Thanks
@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2025

📌 Commit a2b9c8d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 9, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2025
@bors
Auto merge of rust-lang#138279 - matthiaskrgr:rollup-ndnoipr, r=matth…
3ea711f 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#122790 (Apply dllimport in ThinLTO)
 - rust-lang#137650 (Move `fs` into `sys`)
 - rust-lang#138228 (Use `disjoint_bitor` inside `borrowing_sub`)
 - rust-lang#138233 (Windows: Don't link std (and run-make) against advapi32, except on win7)
 - rust-lang#138253 (Continue to check attr if meet empty repr for adt)
 - rust-lang#138263 (Fix `repr128-dwarf` test)
 - rust-lang#138276 (Lazy load NtOpenFile for UWP)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1105f4a into rust-lang:master Mar 9, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 9, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2025
@rust-timer
Unrolled build for rust-lang#138263
9656867 
Rollup merge of rust-lang#138263 - beetrees:fix-repr128-dwarf, r=jieyouxu

Fix `repr128-dwarf` test

The test now correctly ignores enums from `std`.

Fixes rust-lang#138254
Unblocks rust-lang#138200
@weihanglo weihanglo mentioned this pull request Mar 10, 2025
Merged
@beetrees beetrees deleted the fix-repr128-dwarf branch March 22, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

tests/run-make/repr128-dwarf panics when LLVM assertions are enabled
4 participants
@beetrees @rustbot @jieyouxu @bors