Use singlequotes in the typechecker error messages too, to distinguish code and English #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we use backquotes for this type of thing, per #437 (not that I'm crazy about backquotes)? |
|
That issue states: "but single quotes would work too" :) I've seen single quotes in the frontend, i tried to be consistent with that Maybe we should write a macro or function to be consistent and flexible? |
|
I'm fine with single quotes, the few error messages that ever need to be specific about reporting char literals can be careful about it, and I don't expect we're likely to have error messages reporting full interpolated expressions (those can be, and often are, huge). |
graydon
added a commit
that referenced
this pull request
Dec 28, 2011
Use singlequotes in the typechecker error messages too, to distinguish code and English
graydon
added a commit
that referenced
this pull request
Dec 28, 2011
… to grep, can change in the future.
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please correct if i quoted too much.