Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #138637

Closed
wants to merge 15 commits into from
Closed

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Mar 18, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJung and others added 15 commits March 4, 2025 08:44
This clarifies the explanation of why this is not allowed and also what to do instead.

Fixes 62071

PS There was suggestion of adding a link to the book. I did not yet do that, but if desired that could be added.
Co-authored-by: Predrag Gruevski <obi1kenobi82@gmail.com>
This commit fixes an internal compiler error (ICE) that occurs when
rustdoc attempts to process macros with a remapped filename. The issue
arose during macro expansion when the `--remap-path-prefix` option was
used.

Instead of passing remapped filenames through, which would trigger the
"attempted to remap an already remapped filename" panic, we now
extract the original local path from remapped filenames before
processing them.

A test case has been added to verify this behavior.

Fixes rust-lang#138520

Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net>
…rmit, r=tgross35

Implement `read_buf` for Hermit

Following hermit-os/kernel#1606, it is now safe to implement `Read::read_buf` for file descriptors on Hermit.

cc ``@mkroening``
Clarify "owned data" in E0515.md

This clarifies the explanation of why this is not allowed and also what to do instead.

Fixes rust-lang#62071

PS There was suggestion of adding a link to the book. I did not yet do that, but if desired that could be added.
…e, r=GuillaumeGomez,Urgau

Fix ICE: attempted to remap an already remapped filename

This commit fixes an internal compiler error (ICE) that occurs when
rustdoc attempts to process macros with a remapped filename. The issue
arose during macro expansion when the `--remap-path-prefix` option was
used.

Instead of passing remapped filenames through, which would trigger the
"attempted to remap an already remapped filename" panic, we now
extract the original local path from remapped filenames before
processing them.

A test case has been added to verify this behavior.

Fixes rust-lang#138520
…laumeGomez

rustdoc-json: Add tests for `#[repr(...)]`

Works towards rust-lang#137645 and rust-lang#81359

Based on rust-lang#138018, but with only the test changes. CC ``@obi1kenobi``

r? ``@GuillaumeGomez``
rustc_target: Add target feature constraints for LoongArch

Part of rust-lang#116344

r? ```@RalfJung```
@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend O-hermit Operating System: Hermit S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 18, 2025
@jhpratt
Copy link
Member Author

jhpratt commented Mar 18, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Mar 18, 2025

📌 Commit 83f4bc4 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2025
@bors
Copy link
Contributor

bors commented Mar 18, 2025

⌛ Testing commit 83f4bc4 with merge 6c96bb1...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2025
Rollup of 7 pull requests

Successful merges:

 - rust-lang#136320 (exit: document interaction with C)
 - rust-lang#138301 (Implement `read_buf` for Hermit)
 - rust-lang#138508 (Clarify "owned data" in E0515.md)
 - rust-lang#138556 (Fix ICE: attempted to remap an already remapped filename)
 - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`)
 - rust-lang#138608 (rustc_target: Add target feature constraints for LoongArch)
 - rust-lang#138619 (Flatten `if`s in `rustc_codegen_ssa`)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-fuchsia failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
stdout:

stderr:
Cloning into '/checkout/obj/fuchsia/third_party/android/platform/packages/modules/Bluetooth/src'...
remote: RESOURCE_EXHAUSTED: Resource has been exhausted (e.g. check quota)
remote: [type.googleapis.com/google.rpc.QuotaFailure]
remote: violations {
remote:   subject: "ip/4.236.217.64"
remote:   description: "Short term server-time rate limit exceeded"
remote: }
remote: 
remote: [type.googleapis.com/google.rpc.RequestInfo]
remote: request_id: "5596bde6567649769fc80208d97a6f9b"
fatal: unable to access 'https://fuchsia.googlesource.com/third_party/android.googlesource.com/platform/packages/modules/Bluetooth/': The requested URL returned error: 429

command fail error: exit status 128

[05:54:20.248] Wait for 1m4s before next attempt...: Cloning https://fuchsia.googlesource.com/third_party/android.googlesource.com/platform/packages/modules/Bluetooth

[05:55:24.249] Attempt 2/3: Cloning https://fuchsia.googlesource.com/third_party/android.googlesource.com/platform/packages/modules/Bluetooth

[05:55:40.322] WARN: Projects with local changes and/or not on JIRI_HEAD:
third_party/android/device/generic/goldfish-opengl (third_party/android/device/generic/goldfish-opengl): (Has changes)
third_party/pylibs/isort (third_party/pylibs/isort/src): (Has changes)
third_party/android/platform/external/avb (third_party/android/platform/external/avb): (Has changes)
third_party/pylibs/astroid (third_party/pylibs/astroid/src): (Has changes)

To force an update to JIRI_HEAD, you may run 'jiri runp git checkout JIRI_HEAD'
[05:56:35.300] WARN: Some packages are skipped by cipd due to lack of access, you might want to run "/checkout/obj/fuchsia/.jiri_root/bin/cipd auth-login" and try again
++ git -C integration rev-parse HEAD
+ echo integration commit = f6f83d3e3852209f7752be55694006afbe979e50
integration commit = f6f83d3e3852209f7752be55694006afbe979e50
+ bash scripts/rust/build_fuchsia_from_rust_ci.sh
---
You will receive this warning until an option is selected.
To check what data we collect, run `fx metrics`
To opt in or out, run `fx metrics <enable|disable>

ERROR at //build/dist/packaged_shared_library.gni:215:21: Can't load input file.
    public_deps = [ _final_target ]
                    ^------------
Unable to load:
  /checkout/obj/fuchsia/third_party/android/device/generic/goldfish-opengl/BUILD.gn
I also checked in the secondary tree for:
  /checkout/obj/fuchsia/build/secondary/third_party/android/device/generic/goldfish-opengl/BUILD.gn

For more information how to resolve CI failures of this job, visit this link.

@bors
Copy link
Contributor

bors commented Mar 18, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2025
@jhpratt jhpratt closed this Mar 18, 2025
@jhpratt jhpratt deleted the rollup-4bw5bn8 branch March 18, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend O-hermit Operating System: Hermit rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.