Revert: Add *_value methods to proc_macro lib #138661
Merged
+15
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
A-tidy
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. These commits modify the If this was unintentional then you should revert the changes before this PR is merged. The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors p=1 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2025
…r=petrochenkov Revert: Add *_value methods to proc_macro lib This reverts rust-lang#136355. That PR caused unexpected breakage: - the rustc-dev component can no longer be loaded by cargo, which impacts Miri and clippy and likely others - rustc_lexer can no longer be published to crates.io, which impacts RA See rust-lang#138647 for context. Cc `@GuillaumeGomez` `@Amanieu`
|
The job Click to see the possible cause of the failure (guessed by this bot)For more information how to resolve CI failures of this job, visit this link. |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2025
…r=petrochenkov Revert: Add *_value methods to proc_macro lib This reverts rust-lang#136355. That PR caused unexpected breakage: - the rustc-dev component can no longer be loaded by cargo, which impacts Miri and clippy and likely others - rustc_lexer can no longer be published to crates.io, which impacts RA See rust-lang#138647 for context. Cc `@GuillaumeGomez` `@Amanieu`
|
The job Click to see the possible cause of the failure (guessed by this bot)For more information how to resolve CI failures of this job, visit this link. |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Hey friends of Fuchsia! This issue could use some guidance on how this should be |
bors
added
S-waiting-on-bors
|
Taking a look now. |
|
I'm seeing a few rate limit errors by the googlesource.com servers during the checkout phase. One example: There are retries and that seems to complete successfully. Strangely, jiri reports that some of the directories have local changes: This is surprising to me. Is the bootstrapping done on an existing checkout somehow? It then fails on an The file itself does exist when visiting https://cs.opensource.google/fuchsia/fuchsia/+/af693ced69d47dd4cff7c9e43b4a79ed584cf7f7:third_party/go/makeroot/BUILD.gn The missing file lines up with one of the directories jiri reported as having local changes: |
|
The build runs inside Docker, which has a bound volume to a clean checkout of the PR commit being tested. We hopefully shouldn't be modifying the Fuchsia sources in any way. Maybe it's the second cause (missing in HEAD?)? |
|
It exists in HEAD as well https://cs.opensource.google/fuchsia/fuchsia/+/HEAD:third_party/go/makeroot/BUILD.gn, but I checked the revision that was logged. I'm also not able to repro on a fresh local checkout following the same steps. I've reached out to a few folks internally. I'm not sure if I'll hear back from them before I have to head out for the day. If this issue is sporadic, I'd recommend retrying until we can find a solution. |
|
Please use a dedicated issue and not a random PR for discussing problems like this. I made one for you: #138691. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2025
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#136177 (clarify BufRead::{fill_buf, consume} docs) - rust-lang#138654 (Remove the regex dependency from coretests) - rust-lang#138655 (rustc-dev-guide sync) - rust-lang#138656 (Remove double nesting in post-merge workflow) - rust-lang#138658 (CI: mirror alpine and centos images to ghcr) - rust-lang#138659 (coverage: Don't store a body span in `FunctionCoverageInfo`) - rust-lang#138661 (Revert: Add *_value methods to proc_macro lib) - rust-lang#138670 (Remove existing AFIDT implementation) - rust-lang#138674 (Various codegen_llvm cleanups) - rust-lang#138684 (use then in docs for `fuse` to enhance readability) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2025
Rollup merge of rust-lang#138661 - RalfJung:revert-rustc-dev-breakage, r=petrochenkov Revert: Add *_value methods to proc_macro lib This reverts rust-lang#136355. That PR caused unexpected breakage: - the rustc-dev component can no longer be loaded by cargo, which impacts Miri and clippy and likely others - rustc_lexer can no longer be published to crates.io, which impacts RA See rust-lang#138647 for context. Cc `@GuillaumeGomez` `@Amanieu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #136355. That PR caused unexpected breakage:
See #138647 for context.
Cc @GuillaumeGomez @Amanieu